Code Monkey home page Code Monkey logo

Comments (8)

andony-arrieula avatar andony-arrieula commented on June 14, 2024

It seems it's not the data not in the good order, but the preprocessing done in preprocess_dataset which is not performed on the prediction data.

from prophitbet-soccer-bets-predictor.

kochlisGit avatar kochlisGit commented on June 14, 2024

This should happen only during Cross-Validation process and it's perfectly normal. The idea is that we randomly selected a train set and a n evaluation set, to measure the performance of the models.

However, during the training period (ONLY), it should use the first 100 matches as test and the rest of the dataset should be processed in the correct order!
Otherwise, can you print the results of the preprocess_dataset for the evaluation data to verify this?

from prophitbet-soccer-bets-predictor.

andony-arrieula avatar andony-arrieula commented on June 14, 2024

The problem is not on the evaluation data, but on the prediction data passed to the predict match dialog.

For example, I launch my trained model on Ligue 1 French league, I select Paris SG as home team (the best team in the league) and Clermont as away team (the worst team in the league), and I enter the same odd (3.00) for all possible results, the algorithm gives me probabilities of 0.32 for Paris 0.23 a draw and 0.44 for Clermont, which is totally incoherent, and this is because the data given to the model is not processed before it was passed to the model.

from prophitbet-soccer-bets-predictor.

kochlisGit avatar kochlisGit commented on June 14, 2024

So the program grabs the features from the history tables, but does not preprocess them beforing passing them to model for prediction?

from prophitbet-soccer-bets-predictor.

andony-arrieula avatar andony-arrieula commented on June 14, 2024

Exactly !

But the program also does not update the statistics with the data of the previous match !

from prophitbet-soccer-bets-predictor.

kochlisGit avatar kochlisGit commented on June 14, 2024

Thanks. I will take a look into it.

from prophitbet-soccer-bets-predictor.

andony-arrieula avatar andony-arrieula commented on June 14, 2024

I am also looking on that issue on my own side, I think the best way to proceed is to modify the construct_input() method to process the data before giving it to the model to make the prediction.

from prophitbet-soccer-bets-predictor.

kochlisGit avatar kochlisGit commented on June 14, 2024

Yeah, I think that would be the best way. The rows should be processed before returned using the scaler of them model's config (if any)

from prophitbet-soccer-bets-predictor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.