Code Monkey home page Code Monkey logo

Comments (6)

kobalicek avatar kobalicek commented on September 15, 2024

Sorry for inconvenience, I just looked at it and it seems I just copied it from __write_card_pp and forgot to implement it. Will fix it soon.

from amdtweak.

tomasbrod avatar tomasbrod commented on September 15, 2024

You do not have to hurry. I just found that plain reading the pp_table and writing the same data back will crash the driver (rx560), so I won't be able to use this tool anyway.

from amdtweak.

kobalicek avatar kobalicek commented on September 15, 2024

You can email me your pp_table and I can check it out locally (and add it to tests). I remember fixing a similar bug where the library corrupted the table as well.

from amdtweak.

tomasbrod avatar tomasbrod commented on September 15, 2024

I used dd/cat for that exercise.

cat /sys/class/drm/card0/device/pp_table >pp_table
cat pp_table >/sys/class/drm/card0/device/pp_table

Which crashed the driver (null pointer, but somehow no panic).

Your tool behaves correctly after patching the function with a hard-coded path.

from amdtweak.

tomasbrod avatar tomasbrod commented on September 15, 2024

You should patch the function and upload the commit.

from amdtweak.

Lucie2A avatar Lucie2A commented on September 15, 2024

This bug has been fixed with commit 2a4ff77
and with pull request #10.
This bug should be closed now.

from amdtweak.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.