Comments (5)
since we're doing this.request
and this.response
, would be nice if the signature was:
app.use(function* (req, res) {
assert(this.request === req);
assert(this.response === res);
})
because doing this.request
and this.response
or var req = this.request
would be pretty annoying. of course this shouldn't be necessary since a lot of properties are delegated to this
, but i don't see the harm of passing these as arguments. it would also make it more similar to express, especially if you decided to make express 4.0 an opinionated version of koa.
from koa.
possible implementation: koajs/compose#1
variable arity would be pretty simple to do if we compose this way.
from koa.
the one thing I like about not using arguments at all is that it frees up args for stuff like koa-route parameters. which could still use this.request but then it kind of diverges more from other koa related code, but definitely worth a consideration it does look better than if (this.response.header[blahblah])
. The other reason I like it being on this
is that it's reasonably obvious that those are not node's request/response objects since it doesn't match express
hopefully we don't even use those very much in every-day koa code, it just gets awkward with a few of those properties we had. On the other hand I'm totally cool with just doing this.params
again in koa-route, not a huge deal
from koa.
hmmm i'm actually liking doing this.request
and this.response
and it's probably better for users not to worry about arity (as you know, i hate when people check a function's arity. :P). should we close this?
from koa.
yeah might as well close for now I don't have super strong opinions on it, keeps the signature nice and clean :D
from koa.
Related Issues (20)
- [fix] ctx.request.origin ignores proxy flag (X-Forwarded-Proto) HOT 2
- Issue with reassigning ctx.query and type preservation HOT 2
- [feat] send json type content when call ctx.throw HOT 1
- [fix] Has callback() changed return type? Now error from eslint HOT 5
- [feat] Could a listen() shortcut function be added also for http2? HOT 3
- [fix] Some things cannot be found in the database where condition search, unless the where condition search ID HOT 3
- koa 2.14.7 No generics,I want to be able to add generics HOT 1
- [feat] when will koa 3.0 be released? HOT 3
- Koa main website example code snippets disappear HOT 4
- [feat] Objects as middleware HOT 6
- [feat] Support Web (WHATWG) stream, Blob and Response HOT 2
- Consider alternatives to http-assert (including none at all) HOT 4
- [fix] Send response as buffer HOT 4
- async issue on app.listen(...) HOT 4
- [fix] I can not get query parameters about Korean HOT 3
- [feat] Spanish translation for docs
- Routing sucks, moving back to express. HOT 1
- [fix] ctx value persists to next request after mutating ctx object HOT 3
- if "\@" in url ,the redirect result doesn't match the host of the new URL() HOT 2
- [feat] Replace npm dependency "only"
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from koa.