Remove Bluebird about jwt HOT 4 CLOSED

The docs say a promise is returned. This is why I was surprised to find bluebird was brought in to wrap a single function. I don't see an issue bumping the major version to be safe. Really wish koa would go full on v2

from jwt.

My last comment on #58:

After thinking about it a bit more and looking into it, the SemVer spec itself states as point 1:

Software using Semantic Versioning MUST declare a public API. This API could be declared in the code itself or exist strictly in documentation. However it is done, it should be precise and comprehensive.

Since our documentation and koa's documentation on the usage of middleware are as close as we come to having an explicit public API, we either consider that to be our public API or we aren't SemVer.

With this in mind, usage of koa-jwt that extends the library and depends upon using bluebird-only promise methods rather than using it as documented could be considered to not be using the public API. As such, we would not require a major version bump.

Thoughts?

from jwt.

I (kinda) agree on the "misusage" of the API argument. It's a case of "penalizing" not-so-good users. Personally, I wouldn't mind a minor bump for this. But since we cannot safe-guard against all breaking changes, I'd also include some comment on the docs, somewhere. Maybe on the README.md.

from jwt.

[email protected] has released! It's time to face this issue. I think sindresorhus/pify is a good choice. It use native Promise default.

from jwt.