[RFC] Make providers really decoupled about oauth2-client-bundle HOT 3 CLOSED

@okwinza actually, this was good timing. I just added a generic provider that is a catch-all for something that's not supported.

I think it's the best of both worlds: for any providers that we do have, we can set things up with the exact options they need (with validation), a custom Client class (that's a new thing I just added this morning), and generate the README with specific instructions. For anything we don't have, use the generic. I agree that requiring this bundle to support every provider is a bad idea - I don't want someone to get frustrated and not be able to get something done because we (for example) haven't merged a PR for some provider.

What do you think about the generic provider? I think it covers us (check the end of the README - it shows the usage - very similar to your configuration actually).

from oauth2-client-bundle.

@weaverryan So bad i completely missed that issue #6
Yeah i think it makes sense and provides a way to set up most of Oauth providers without any pain.

I think we can stick for that and see how it goes. I'm concerned about some edge cases tho(shitty implementation of Oauth RFC on server's end for example) that would require some coding but let see if that would be a thing.

from oauth2-client-bundle.

@okwinza yep, good call - we can open things up as people ask, I'd be happy to do that.

Btw, I don't have any other blockers I'm aware of for a 1.0, so unless I hear of something, I'll make that release pretty soon.

Thx for the conversation - nice to have some eyes on the library early!

from oauth2-client-bundle.