Code Monkey home page Code Monkey logo

Comments (18)

kkkrist avatar kkkrist commented on June 11, 2024

I'm sorry, but I can't reproduce. I'm using exactly the same version of Chromium (mac-stable-ungoogled-marmaduke) and it works fine.

Are you tracking extension updates?

Are there any error messages shown in the popup window devtools? (right-click somewhere in the popup window, click "inspect" and select "console" tab)

from chromium-notifier.

 avatar commented on June 11, 2024

Well...
this
But every time I close Chromium and start it again it says "New" at the icon, and then I click it, see nothing new... the "New" hint is gone, and then appears again after some minutes.

I got Windows 10 19044.1645 x64 btw

No errors at the console in dev tools.

from chromium-notifier.

kkkrist avatar kkkrist commented on June 11, 2024

That's really weird. The check interval is set to 3 hours. I really wonder what's triggering the "New" badge to re-appear after just a few minutes?

I'll try to set up a Windows VM and test with the exact build you're using when I have more time. You could also enable error tracking to have the extension send me any errors possibly happening in the background anonymously.

from chromium-notifier.

 avatar commented on June 11, 2024

I enabled error tracking now. Thanks for your work, Sir.

from chromium-notifier.

emilsimunovic avatar emilsimunovic commented on June 11, 2024

I have same problem with win64 Chromium. I get NEW icon notification every hour or so. Even by just clicking settings/enable error tracking the NEW icon will pop.
image

from chromium-notifier.

 avatar commented on June 11, 2024

I uninstalled the plugin some weeks ago. It has no use for me with that bug. It's as good as looking at the release page for a new version after some days.

from chromium-notifier.

emilsimunovic avatar emilsimunovic commented on June 11, 2024

I am sure it is a simple fix, I hope it will be solved soon.

from chromium-notifier.

kkkrist avatar kkkrist commented on June 11, 2024

Unfortunately, the error tracker didn't catch anything on that matter yet and I still can't reproduce the problem. I also don't think it's a general issue. The extension still seems to be used by many (error tracker and proxy usage suggest 1000+ users) and there should've been more bug reports like this if it is.

There's just one single call in the whole extension that sets the badge to "New". It's part of the main() function that's being run every ~180 mins by a timer and it only sets it to "New" under the following conditions:

  • The latest Chromium version available could successfully be fetched from the Woolyss API and the currently running version does not match
  • If "Track extension updates" is enabled: The latest versions for currently installed extensions could successfully be fetched from the proxy or the Chrome Web Store API and any one of it does not match what's currently installed.

It's a mystery as to why the "New" badge pops up every few minutes when the timer should only run every 180 minutes.

from chromium-notifier.

kkkrist avatar kkkrist commented on June 11, 2024

Here's a debug version that logs these conditions to the console before it sets the badge to "New":

chromium-notifier-debug.crx.zip

After the bug occurs, please go to chrome://extensions/, click on "background.html" to open a devtools instance of the extension and tell me what's logged to the console tab!

(Please expand the logged object like this before you take a screenshot or copy/paste:)
Bildschirmfoto 2022-05-24 um 11 40 22

from chromium-notifier.

emilsimunovic avatar emilsimunovic commented on June 11, 2024

With chromium-notifier-debug.crx I did not get NEW notification at all. I don't understand whay is that. Will test is more for next couple days and also see what happens when actual update landed.

from chromium-notifier.

emilsimunovic avatar emilsimunovic commented on June 11, 2024

Chromium v102.0.5005.63 just landed and chromium-notifier-debug.crx worked how is should. I do not get any error notifications anymore. So what it different between chromium-notifier-debug.crx vs chromium-notifier.crx ?

from chromium-notifier.

kkkrist avatar kkkrist commented on June 11, 2024

The difference is really only this one conditional console.log call:

diff --git a/js/background.js b/js/background.js
index 8baed35..3922072 100644
--- a/js/background.js
+++ b/js/background.js
@@ -129,6 +129,14 @@ chrome.storage.onChanged.addListener(async () => {
 
   const { uaFullVersion } = await getUserAgentData()
 
+  if ((current && uaFullVersion !== current.version) || extensionsNew) {
+    console.log({
+      current,
+      uaFullVersion,
+      extensionsNew
+    })
+  }
+
   chrome.browserAction.setBadgeText({
     text:
       (current && uaFullVersion !== current.version) || extensionsNew

This is beyond weird!

If the debug version keeps working, could you try re-installing the last stable version from scratch and see if the problem is gone?

from chromium-notifier.

emilsimunovic avatar emilsimunovic commented on June 11, 2024

This is strange, after re-installing last stable everything seams fine. I have no false NEW icon problems. I will report back if I get it again...

from chromium-notifier.

kkkrist avatar kkkrist commented on June 11, 2024

How often do you usually restart Chromium? Does it run for days and weeks on end because you typically only suspend your computer?

from chromium-notifier.

kkkrist avatar kkkrist commented on June 11, 2024

@ryder203 Can you try re-installing from scratch and tell if it helps for you too?

from chromium-notifier.

emilsimunovic avatar emilsimunovic commented on June 11, 2024

So far so good. I newer turn of my computer. Restart after update and that's about it.

from chromium-notifier.

 avatar commented on June 11, 2024

@ryder203 Can you try re-installing from scratch and tell if it helps for you too?

I'm not at home for the next days and if I don't forget it I'll try next week when I'm back on my computer.

from chromium-notifier.

kkkrist avatar kkkrist commented on June 11, 2024

Closing for now. I assume this is some weird extension state management issue in upstream. Feel free to re-open if any new info emerges or you find a way to re-produce.

from chromium-notifier.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.