CI failure with Swift 5 about kiturakit HOT 8 CLOSED

created PR apple/swift-corelibs-foundation#2061

from kiturakit.

@Andrew-Lees11 could you document the double invocation of the callback you found from URLSession.dataTask when Kitura sends a 401: Unauthorized response? And also link to the StackOverflow issue you found which is likely to be the same / related to this.

I wonder if this is somehow related to apple/swift-corelibs-foundation#1569 - in which case maybe @saiHemak could investigate?

from kiturakit.

I created a gist that would recreate the test failure here.

When a Kitura server returns a 401 unauthorized code the callback on URLSession.dataTask is called twice. once with "The operation could not be completed" and then with the response from Kitura. This is not true for other error codes and only happens on Swift 5 on Linux.

I think This Stackoverflow error May be running into the same problem since it is only failing on Linux but i'm not entirely sure.

from kiturakit.

Could successfully recreate the issue from TestFoundation. Upon instrumenting the code I could see the TaskRegistry.remove is getting called twice . Instrumenting further to identify why the remove call has been triggered twice ..

from kiturakit.

@saiHemak this seems to be reported over Twitter too https://twitter.com/mxcl/status/1111073495017029635

from kiturakit.

session.taskRegistry.remove(task) has been called twice once from urlProtocol(`protocol`, didFailWithError: urlError) and the from the switch case case .dataCompletionHandler(let completion):

from kiturakit.

Please open an issue to track re-enabling these tests once Swift 5.0.1 ships with the fix.

from kiturakit.

Raised an issue to uncomment the tests here

from kiturakit.