Code Monkey home page Code Monkey logo

Comments (23)

KittyKatt avatar KittyKatt commented on May 29, 2024 1

I'm going to mark this as WONTFIX at this point. Closing.

from screenfetch.

KittyKatt avatar KittyKatt commented on May 29, 2024

They're the best. I'll look at this tomorrow.

from screenfetch.

KittyKatt avatar KittyKatt commented on May 29, 2024

Is there any update on this @ShanaTsunTsunLove?

from screenfetch.

Fuuzetsu avatar Fuuzetsu commented on May 29, 2024

Ooops, I think I missed your update a month ago. Sorry to keep you waiting.
screenfetch

from screenfetch.

KittyKatt avatar KittyKatt commented on May 29, 2024

Grrr. That's a pesky bug you have there. Might have to break out the spray.

from screenfetch.

KittyKatt avatar KittyKatt commented on May 29, 2024

Blech. I will get to this, I promise.

from screenfetch.

spaghetti2514 avatar spaghetti2514 commented on May 29, 2024

I think the issue might be that you're checking for the substring "invalid window id format" when you need to be checking for "Invalid window id format"

from screenfetch.

KittyKatt avatar KittyKatt commented on May 29, 2024

I completely forgot this was open. That MIGHT be a problem. Hmmm...lemme check. That could DEFINITELY be the problem.

Check the referenced commit.

from screenfetch.

Fuuzetsu avatar Fuuzetsu commented on May 29, 2024

Even worse.

fetch

from screenfetch.

KittyKatt avatar KittyKatt commented on May 29, 2024

Wow, that was quick for an old issue! Thanks for check it so quickly. Hmmm....tricky bug you got here. Oh. Wait.

I put something in recently to help with WM name case-sensitiveness and that's what's causing those declare errors. I wonder why that's a problem for your setup? Maybe an older version of BASH?

from screenfetch.

Fuuzetsu avatar Fuuzetsu commented on May 29, 2024
GNU bash, version 3.2.25(1)-release (x86_64-redhat-linux-gnu)
Copyright (C) 2005 Free Software Foundation, Inc.

from screenfetch.

Fuuzetsu avatar Fuuzetsu commented on May 29, 2024

I just remembered that there's zsh on this box as well. After a rather long wait (60 sec+) here's what I get. Mind that this is a headless box (or rather, it has X installed but I'm SSHing to it without doing anything like X forwarding).

zsh 4.2.6 (x86_64-redhat-linux-gnu)

fetch1
fetch2

from screenfetch.

KittyKatt avatar KittyKatt commented on May 29, 2024

Ah yes! That will do it. Okay, I've corrected THAT bug with latest commit (adc2324) and now we can get back to working on your other one. Would you test to make sure it's actually fixed?

Also, that just refreshed for me. Running through ZSH will not result in the same output and WILL error on some things.

And...headless. So...WM info shouldn't be showing up at ALL?

from screenfetch.

Fuuzetsu avatar Fuuzetsu commented on May 29, 2024

I confirm that it's back to just throwing

xprop: error: Invalid window id format: _NET_SUPPORTING_WM_CHECK.
xprop: error: Invalid window id format: _NET_SUPPORTING_WM_CHECK.

from screenfetch.

KittyKatt avatar KittyKatt commented on May 29, 2024

So, can we confirm that this is a box not running X? So it shouldn't be displaying X-dependent values in the first place?

from screenfetch.

KittyKatt avatar KittyKatt commented on May 29, 2024

OH DAMMIT. I know why it's STILL throwing those errors. [[ ]] is a BASH 4.0+ thing, iirc. So it has no idea what to do with those. HM.

from screenfetch.

Fuuzetsu avatar Fuuzetsu commented on May 29, 2024

I did a little experimentation just now. All the times throughout this bug I have been using ssh -Y (because ssh -X doesn't work for various reasons). Just using plain ssh without unecrypted X forwarding (-Y) behave correctly for a headless box

correct

I'm unsure whether this invalidates this bug and it's something that I need to fix on my end.

from screenfetch.

KittyKatt avatar KittyKatt commented on May 29, 2024

Well, ssh -Y implies X-Forwarding, so it thinks there is an X session there. Which is why it is throwing X dependent output in the first place and erroring because there is no $DISPLAY.

The problem, however, will still persist for anyone running BASH pre-4.0 on a machine running X.

from screenfetch.

KittyKatt avatar KittyKatt commented on May 29, 2024

Can we confirm the above @Fuuzetsu?

from screenfetch.

Fuuzetsu avatar Fuuzetsu commented on May 29, 2024

Sorry, I didn't realise you wanted me to confirm anything.

$DISPLAY is set and X forwarding works as seen on the screenshot (limolssh is just an alias for ssh which includes -Y)

displayset

from screenfetch.

KittyKatt avatar KittyKatt commented on May 29, 2024

Honestly, since your BASH is so far behind, I'm not even sure where to start on making it compatible. I may be forced to mark this one WONTFIX. :/

from screenfetch.

Fuuzetsu avatar Fuuzetsu commented on May 29, 2024

Well, personally I don't actually care about this working on bash 3.* and I only reported it because I happened to spot the bug. Let me know if you WONTFIX for bash 3 so that I can file an appropriate dependency issue with my distro.

There does remain the issue of it not working in zsh though, doesn't it? I posted the screenshot of what happens on the same box with zsh few comments up. I'm not sure if it's the same bug or what.

from screenfetch.

KittyKatt avatar KittyKatt commented on May 29, 2024

zsh doesn't contain a lot of BASHISMs that screenfetch relies on. Such as [[ ]] operators and some other such things. screenfetch also explicitly asks for BASH functionality at certain points.

I do believe your problems are related to BASH -4.0 but I need to look into it a little more. I REALLY hate marking ANY bug/issue as WONTFIX, so I'll leave this open for now. Thank you very much for reporting this!

from screenfetch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.