Code Monkey home page Code Monkey logo

Comments (4)

pierremtb avatar pierremtb commented on August 20, 2024

@jessfraz Did you run into bumps when trying it on LFS files? Support was added from the get-go, see tests at

diff-viewer-extension/src/chrome/diff.test.ts

Lines 13 to 41 in 32500a1

describe('Function downloadFile', () => {
it('downloads a public regular github file', async () => {
const github = new Octokit()
// https://github.com/KittyCAD/kittycad.ts/blob/0c61ffe45d8b2c72b3d98600e9c50a8a404226b9/example.obj
const response = await downloadFile(
github,
'KittyCAD',
'kittycad.ts',
'0c61ffe45d8b2c72b3d98600e9c50a8a404226b9',
'example.obj'
)
// TODO: add hash validation or something like that
expect(response).toHaveLength(37077)
})
it('downloads a public LFS github file', async () => {
const github = new Octokit()
// https://github.com/pierremtb/SwGitExample/be3e3897450f28b4166fa1039db06e7d0351dc9b/main/Part1.SLDPRT
const response = await downloadFile(
github,
'pierremtb',
'SwGitExample',
'be3e3897450f28b4166fa1039db06e7d0351dc9b',
'Part1.SLDPRT'
)
// TODO: add hash validation or something like that
expect(response).toHaveLength(70702)
})
})

We should make these point to the new diff-samples repo, maybe creating a diff-samples-lfs repo as well? Or rather add new lfs files and a branch and PR. But we do have LFS support and these tests should attest of that

from diff-viewer-extension.

pierremtb avatar pierremtb commented on August 20, 2024

Added a .dae file tracked as LFS at https://github.com/KittyCAD/diff-samples/tree/hex-lfs. The extension failed, need to understand why. Also noticed spinning loader with a failure in the log. We're missing some error messages for the user. Created #188

from diff-viewer-extension.

org-projects-app avatar org-projects-app commented on August 20, 2024

pierremtb added this issue to 2023 Q2 - Ends June 30th.

from diff-viewer-extension.

pierremtb avatar pierremtb commented on August 20, 2024

So in summary:

  • we do have LFS support, the downloadFile method retrieves the files in all cases;
  • we only have unit test coverage but not e2e, so to close this ticket we'll wait on a PR that adds one.

from diff-viewer-extension.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.