Code Monkey home page Code Monkey logo

Comments (7)

Kissaki avatar Kissaki commented on August 12, 2024

I noticed they do not work for me, but thought it was because of some special characters.
I guess I will have to look into this again.

The links worked for you with the previous version?

from mumpi.

nicolasjoly avatar nicolasjoly commented on August 12, 2024

Yes and by changing "connecturlTemplate" back to it's original values (getting the line from 2.2.5 and putting it in 2.2.6), it works again.

from mumpi.

Kissaki avatar Kissaki commented on August 12, 2024
$connecturlTemplate = 'mumble://MYIP:64738' . urlencode(SettingsManager::getInstance()->getServerAddress($server->getId())) . '%s?version=1.2.8';

does not really make sense though.

That will produce an URL with IP and port, but the port is not a valid port.
It does not produce valid urls for me at all.

I guess you do not have $viewer_serverAddresses configured for the server?

The version as it is works for me with trivial alphanumeric channel names.
Ones with a space do not work currently.
But I can not see the issue or solution you describe.

from mumpi.

nicolasjoly avatar nicolasjoly commented on August 12, 2024

With my change, the URL seems fine. I can click it and it will connect to my server no problem. Here's what it looks like in your JSON that I'm using:

"x_connecturl":"mumble://111.111.111.111:64738?version=1.2.12"

from mumpi.

Kissaki avatar Kissaki commented on August 12, 2024

Do you have $viewer_serverAddresses configured in settings.inc.php?

from mumpi.

Kissaki avatar Kissaki commented on August 12, 2024

Close as no further input/response. Works for me, unreproducible, implausible fix description.

from mumpi.

Kissaki avatar Kissaki commented on August 12, 2024

The mentioned space character issue is/was tracked in #56 (fixed in 6767d5a).

from mumpi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.