Code Monkey home page Code Monkey logo

Comments (9)

kirill-konshin avatar kirill-konshin commented on May 22, 2024 1

I suspect that window hack will be the default behavior, I suggest to name the property like __NEXT_REDUX_STORE__ or something similar... Don't hesitate to send a PR :)

The lib itself should not be hot-reloaded, because it does not change so referentially it should always be one object. Anyway, window fix should be just fine.

I have pushed a quick fix for you guys, you can install master branch and use it right away.

from next-redux-wrapper.

kirill-konshin avatar kirill-konshin commented on May 22, 2024 1

Published.

from next-redux-wrapper.

kirill-konshin avatar kirill-konshin commented on May 22, 2024

Good catch! Thanks. I will fix it in the next few days.

from next-redux-wrapper.

neogermi avatar neogermi commented on May 22, 2024

I just stumbled over this. Is there any workaround for this that we could apply fast?

from next-redux-wrapper.

timotgl avatar timotgl commented on May 22, 2024

@neogermi as a quick and dirty hack you can fork this library and attach (and restore) the store instance to the window object in the memoization function.

from next-redux-wrapper.

kirill-konshin avatar kirill-konshin commented on May 22, 2024

Fixed in 1.1.3

from next-redux-wrapper.

neogermi avatar neogermi commented on May 22, 2024

Great thank you! Currently, 1.1.3 is not available through npm. When do you plan to publish it?

from next-redux-wrapper.

kirill-konshin avatar kirill-konshin commented on May 22, 2024

Oops, something went wrong with NPM publish after Travis CI, I will fix that tomorrow first thing in the morning.

from next-redux-wrapper.

neogermi avatar neogermi commented on May 22, 2024

great thank you for the fast response!

from next-redux-wrapper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.