Comments (11)
I wander if I can take this one?
from kimchi.
Sure... I will assign it to you.
from kimchi.
@lvroyce, this issue is pending on 5 months. please fix it ASAP.
Thanks.
from kimchi.
duplicate with issue 90
#90
from kimchi.
Issue #90 is about using a single instance of websockify to handle all kimchi connections (instead of create one instance per connection)
And this issue is about incorporate websockify into cherrypy that way we can eliminate the use of websockify script.
from kimchi.
actually, @wudx05 can fix the the #90 by token.
after his patch, he can satisfy the requires of this issue #22
1. just requires one port to be opened through the firewall
2. do not need more than one websockify process.
from kimchi.
@wudx05 any comments?
from kimchi.
I don't see any other benefits to incorporate websockify into cherrypy. Aline, could you please elaborate why we need incorporate websockify into cherrypy? IMO, we can close this issue
from kimchi.
This already fixed by Markwu.
from kimchi.
@wudx05 As proposed by Adam, integrating websockify into cherrypy can eliminate the need of manage and clean up the spawned websockify processes.
from kimchi.
Kimchi does not launch an external process for websockify anymore.
Instead of that, Kimchi is relying on python-websockify to enable the websockets connection
(commit 613650d)
Based on that, I don't think this issue makes sense in the current scenario.
I will close it by now, but feel free to reopen if you think anything else can be done on that area.
from kimchi.
Related Issues (20)
- Kimchi not starting on Fedora29 HOT 3
- No VNC in Centos 8 HOT 1
- source install: kimchy plugin fails on import HOT 2
- News about Kimchi 3.0.1 ? HOT 12
- Kimchi/Wok fails after a reboot HOT 1
- Virtualization tab is not available HOT 1
- "/var/lib/kimchi/screenshots" always generate pictures,how to stop it?
- Migration fails with "AttributeError: 'str' object has no attribute 'decode'"
- Guest add volume size missmatch
- Ubuntu 20
- Can not install on ubuntu 21.04 HOT 2
- Clonezilla migration with error booting from hard drive HOT 1
- Spice console not working on Ubuntu 20.04 - ReferenceError: SpiceMainConn is not defined HOT 2
- Kimchi Debian 11 "View Console" not working
- Ubuntu 20.04 kimchi virtualization tab HOT 3
- libvirt: QEMU Driver error HOT 1
- Debian 12 + Qemu 7.2.4 - Spice detection does not work / no longer needed?
- This project seems abandoned HOT 2
- hello mr.. Please immediately fix the turnip driver on Snapdragon 7s Gen2, it won't work yet, keep force closing
- cannot extend file '/var/lib/kimchi/isos/debian-12.5.0-amd64-netinst.iso': File too large
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kimchi.