Comments (11)
pls assign to me
from kimchi.
Enriching the response codes, and embedding a user consumable, translated message in the response body is the first step in improving this flow. A stack trace would not be very friendly feedback, but should be logged. Ideally the message would give the user some action they can take to correct the problem. As we enrich the feedback, we'll want to revisit the UI presentation of messages in general. Assigning to Royce at her request to get the API updated. I'll work w/ Lise to get a design update for better presentation.
from kimchi.
Royce, Lise is working on an update to the UI mockup. Let me know when you complete the API support for this, and I'll assign it to one of the UI specialists to implement the new UI. Hopefully those 2 things come together about the same time.
from kimchi.
adamkingit , patches are already waiting for review here: https://groups.google.com/forum/#!topic/project-kimchi/XI3uDTTfxPI
UI can use this patch set in reference with tests/test_exception.py. I'll appreciate any comments.
from kimchi.
fix by 1846daa, please close it.
from kimchi.
Shaohef. I think in order to mark this completed, the UI will need to use the information to produce a better error message for the user.
from kimchi.
Do you mean UI need to handle json error response the get from backend?
from kimchi.
@shaohef 1846daa is not the same thing with this issue, instead, it's about 404 error when the server can't find the requested URL.
@lvroyce I think your patch already made the server ready for this, I will send a UI patch for this issue. When I did UT, I found the error message is always in English. Do we need translate it? I think it will be more user-friendly.
from kimchi.
@hlwanghl:
Yes, we do need to translate it.
Actually, We already know there is a bug which block the translation.
I have looked into it with lvroyce, but no result.
Just guess _cp_config make wsgiserver take over the error.html
should we file a issue?
here is the error:
INFO:cherrypy.access.23157008:127.0.0.1 - - [13/Aug/2013:22:41:54] "GET /ddd/ddd HTTP/1.1" 404 1399 "" "Mozilla/5.0 (X11; Linux x86_64; rv:22.0) Gecko/20100101 Firefox/22.0"
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/cherrypy/wsgiserver/wsgiserver2.py", line 1302, in communicate
req.respond()
File "/usr/lib/python2.7/site-packages/cherrypy/wsgiserver/wsgiserver2.py", line 831, in respond
self.server.gateway(self).respond()
File "/usr/lib/python2.7/site-packages/cherrypy/wsgiserver/wsgiserver2.py", line 2126, in respond
chunk = chunk.encode('ISO-8859-1')
UnicodeEncodeError: 'latin-1' codec can't encode characters in position 501-502: ordinal not in range(256)
from kimchi.
@aglitke maybe you should tag this as 1.1 Release
we should refactor exception, @zhoumeina and I file a wiki about it. https://github.com/kimchi-project/kimchi/wiki/refactor-exception-%5Brelease-1.1%5D
from kimchi.
from kimchi.
Related Issues (20)
- Kimchi not starting on Fedora29 HOT 3
- No VNC in Centos 8 HOT 1
- source install: kimchy plugin fails on import HOT 2
- News about Kimchi 3.0.1 ? HOT 12
- Kimchi/Wok fails after a reboot HOT 1
- Virtualization tab is not available HOT 1
- "/var/lib/kimchi/screenshots" always generate pictures,how to stop it?
- Migration fails with "AttributeError: 'str' object has no attribute 'decode'"
- Guest add volume size missmatch
- Ubuntu 20
- Can not install on ubuntu 21.04 HOT 2
- Clonezilla migration with error booting from hard drive HOT 1
- Spice console not working on Ubuntu 20.04 - ReferenceError: SpiceMainConn is not defined HOT 2
- Kimchi Debian 11 "View Console" not working
- Ubuntu 20.04 kimchi virtualization tab HOT 3
- libvirt: QEMU Driver error HOT 1
- Debian 12 + Qemu 7.2.4 - Spice detection does not work / no longer needed?
- This project seems abandoned HOT 3
- hello mr.. Please immediately fix the turnip driver on Snapdragon 7s Gen2, it won't work yet, keep force closing
- cannot extend file '/var/lib/kimchi/isos/debian-12.5.0-amd64-netinst.iso': File too large
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kimchi.