Comments (4)
Yes, these functions do call each other, but as far as I can determine the following piece of code in updateTorrents()
should prevent calling getErrorData()
for torrents that have the errorString set. Barring some rare possible race condition of course.
t.update( torrent );
if( t.error !== 0 && isEmpty( t.errorString ) ) {
eids.push( t.id )
}
Please point out my mistake, if any.
from shift.
Oh yes-ish, you're right! I had those checks disabled locally and forgot about that, sorry...
But, but that piece is preventing almost all errors from notification. In other words, with those checks intact, updateTorrents()->getErrorData()
path is actually doing nothing. Even if any went through it, it doesn't make sense: t.errorString
is now guaranteed to be Empty, so down the path sendNotification()
won't generate any meaningful message. I'm not sure how those supposed to work. I'm confused...
from shift.
Oh yes-ish, you're right! I had those checks disabled locally and forgot about that, sorry...
So disabling these conditions actually caused the infinity which caused you to file this issue. Why do this?
But, but that piece is preventing almost all errors from notification. In other words, with those checks intact,
updateTorrents()->getErrorData()
path is actually doing nothing. Even if any went through it, it doesn't make sense:t.errorString
is now guaranteed to be Empty, so down the pathsendNotification()
won't generate any meaningful message. I'm not sure how those supposed to work. I'm confused...
Please do your research before making these claims. So closing until an actual issue needs to be addressed.
from shift.
Sorry for noises and inconveniences I made, I now realized that in normal circumstances, unmodified sendNotification()
is actually just a null func for the time being, because Notification.requestPermission( f )
will never succeed (undefined f
). So all the trouble was of mine and just moot.
(as to why: I usually have dom.webnotifications.enabled=false
set, so I just added console.log
to sendNotification()
on sight. Then I found it logging Torrent error. "...":
(nothing after :
) everytime at opening shift. I naively assumed that those null error should not reach to sendNotification()
, and thoughtlessly flipped the logic. It looked okay at that time without errored ones, errors don't happen often, and I forgot about that totally. oops...)
Anyway thanks for your work!
from shift.
Related Issues (20)
- Screenshots HOT 5
- custom rpc-url HOT 2
- RATIO HOT 1
- Shift does play well with Transmission 2.92+ (14736) HOT 2
- Can't remove a tracker HOT 2
- Add registerProtocolHandler to support magnet: links HOT 2
- Add an active status HOT 1
- ETA vs Done Date HOT 3
- serving files HOT 1
- Language support HOT 3
- release zip HOT 4
- Names not displayed for torrents that have labels
- adding trackers to torrents (using FreeBSD): not working HOT 8
- start-added-torrents ignored HOT 1
- peer-port toggle in settings HOT 1
- Improvements for touch devices HOT 2
- [Theme submission] The "I suck at CSS" dark theme HOT 2
- How do I use/install this? HOT 1
- WebUI breaks in latest update. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from shift.