Framework includes multiple versions of json.hpp about vulkan-samples HOT 3 OPEN

An alternative for tinygltf is to define TINYGLTF_NO_INCLUDE_JSON and use the version of nlohmann json that we want. In either case, we likely need to bump our tinygltf version as its 5 years old!

Not sure where HWCPipe includes nlohmann json. Looked through its source tree and couldn't find it. Thats not to say it isn't there!

We are wanting to improve the gltf loader to support more gltf extensions. When we do this, that would be a good time to resolve this issue

from vulkan-samples.

I second that. While tinygltf is indeed outdated, we don't actually use any functionality that would require us an update. On the other hand updating would require us the test all the samples and make sure stuff still works as expected. Just like Tom this should be part of our larger framework rework roadmap.

from vulkan-samples.

The version of TinyGLTF currently embedded doesn't support TINYGLTF_NO_INCLUDE_JSON, however, I do notice now that it's inclusion of json.hpp only happens inside a #if defined(TINYGLTF_IMPLEMENTATION) block, so the problem is significantly more tractable as its simply a matter of declaring the proper include guard define inside the gltf_loader.cpp right after #define TINYGLTF_IMPLEMENTATION to ensure the outdated JSON header isn't included along with the one from hwcpipe.

from vulkan-samples.