Suggestion: Refactor (HPP)Image & (HPP)Buffer to improve VMA usage and reduce duplicated code. about vulkan-samples HOT 6 CLOSED

Note in this case I've explicitly set up the builder ctor to require any params without which the resulting object would make no sense. In the case of Images that's the extent and the format, although even the format is defaulted in the ctor. In the case of buffers it's just the size.

from vulkan-samples.

Hey @jherico, great ideas!

I agree that we are a little bloated in this area. There is an ongoing initiative to simplify the framework. I think i have a branch with a pattern like this on. Just hard to get in as nearly every place in the framework uses the existing interface so there are a lot of places that need changing.

I agree that a builder pattern could simplify how we create images

from vulkan-samples.

I've got a branch that does this partially, built on top of the VMA version update. I'll see if I can whip it into shape and put it up.

from vulkan-samples.

Feel free to request my review when your ready, I'll try be prompt

from vulkan-samples.

@tomadamatkinson it's #906

The current PR just sets up the new builder ctors without removing the old ones, but it does change a few uses inside the framework.

from vulkan-samples.

This sounds similar to what @asuessenbach is working on in #880. We should talk about how this fits into our framework roadmap.

from vulkan-samples.