Windows Build and Test Fail about tota11y HOT 6 CLOSED

I'm phasing out the open line very soon - we have some unit tests up for review on our internal code review tool, so npm test will be running mocha tests instead of opening the browser.

The part about leaving out run is quite interesting, thank you for looking into this! I would probably prefer to the documentation to say something along the lines of:

npm install
npm run build   # or "npm build" on Windows

What do you think? I'll include that README change with my unit tests so they'll ship simultaneously.

from tota11y.

Yes, mocha tests would definitely be an upgrade. Yes, a simple comment with build also works. Add this to your README change list. I think there would definitely me more before you ship out next version.
Cheers! @jdan

I am looking into #13 as well. Is that included in your next release as well. I included an congratulatory message for that issue in my local repository. Do you want me to push to master?

from tota11y.

@ankitaggarwal011 Yes features can branch right off master for now - no specific release cycle here. Thank you for your enthusiasm!

from tota11y.

@ankitaggarwal011 Okay the README is updated, and unit tests have landed in master. Let me know what you think.

from tota11y.

@jdan , I synced the new changes in my local repository and tested for the updated commands on Windows 7(x64).
Some interesting things happened (you will need to make some changes again). All these commands are working now:

npm install 
npm run build
npm test
npm run lint
npm run live-test

Building the package gives warnings, but that's a different issue.

I am sorry for raising false alarms, but I reported what happened earlier. Now, those errors are gone. I am not sure why these things happened. Could be Windows specific behavior (I didn't even restart the system since reporting the issue). Puzzled. But, you can remove those windows specific lines from README as they are no longer a problem.

from tota11y.

@ankitaggarwal011 👍

from tota11y.