Only a space is added if I try to apply auto suggestions when context is empty about keyboardkit HOT 4 CLOSED

Hi @rubenspessoa

Thank you for clarifying! I will look into this 👍

from keyboardkit.

Hi @rubenspessoa

Happy to hear that you like the library and thank you for letting me know about your problems.

KeyboardKit 8.5.1 adjusted some autocomplete bugs when it comes to empty text. Can you upgrade and see if it solves the problem?

from keyboardkit.

This will be fixed in 8.7 and available in the v8.7 branch later this week.

from keyboardkit.

Hi @danielsaidi,



Thanks for your response. I’ve updated to the latest version (8.5.2) version but unfortunately can still reproduce the bug. I’ll share the stacktrace and my suspicion:





1. KeyboardContext+ProxyBridging.insertAutocompleteSuggestion(_ suggestion: Autocomplete.Suggestion,, tryInsertSpace: Bool = true)
2. UITextDocumentProxy+Autocomplete.insertAutocompleteSuggestion(_ suggestion: Autocomplete.Suggestion, tryInsertSpace: Bool = true)
3. UITextDocumentProxy+Words.replaceCurrentWord(with replacement: String)


That’s where the problem occurs, in the first line of the replaceCurrentWord method we have:

guard let word = currentWord else { return }

But currentWord resolves as nil when the context is empty. It's a computed variable that's created as following:


var currentWord: String? {
  let pre = currentWordPreCursorPart
  let post = currentWordPostCursorPart
  if pre == nil && post == nil { return nil }
  return (pre ?? "") + (post ?? "")
}


And since the context is empty, pre == nil resolves to true, post == nil also resolves to true and the currentWord returns nil.

Since it resolves to nil, replaceCurrentWord returns early and, following the normal app flow, just the space is added to the context.

I'm not sure if any changes here could result in major consequences in the app functionality, but I hope this helps the team to spot the issue and improve the library even further! Thanks guys, let me know if I can help in anything.

from keyboardkit.