Comments (13)
Maybe use this callback? https://github.com/kevva/bin-wrapper/blob/master/bin-wrapper.js#L91.
from bin-wrapper.
Hmm, is that the only way it can fail? I basically want it shown on all failures.
from bin-wrapper.
This is basically the last resort. There's another callback on .check()
to see if a current/downloaded binary works or not. Don't think there's a lot more places it can fail.
from bin-wrapper.
Ok, since 5d0f504 every error is emitted through the error
event.
from bin-wrapper.
@kevva but do we handle it and print out helpful instructions? otherwise this isn't really fixed.
from bin-wrapper.
Should be handled on the error
and fail
events by the packages using this imo.
from bin-wrapper.
opened tickets ;)
from bin-wrapper.
what's the difference between fail
and error
?
from bin-wrapper.
It will emit fail
when it can't find a precompiled binary or if the precompiled binary exits with !== 0
code.
from bin-wrapper.
But why the differentiation?
from bin-wrapper.
Because you don't want to run build after all errors, just when the check fails. The build method emits error itself when it fails which would cause a loop.
Mostly, build will only run on fail
.
from bin-wrapper.
@kevva maybe clarify that in the readme? the events aren't even documented except for in the example.
from bin-wrapper.
Sure, I need to finish up on the addUrl
method first so that everything works.
from bin-wrapper.
Related Issues (20)
- Install error `Cannot find module`. HOT 1
- Support for JAR files HOT 1
- API improvements HOT 2
- Should not make assumptions based on process architecture
- prefer to use system binary if available HOT 2
- Update dependencies HOT 3
- Add support of choosing binary based on standard lib c library. HOT 1
- Cannot download when behind proxy
- migration from `download` to `got` HOT 1
- Bump download dependency HOT 4
- Regression: File is not set to be executable after download HOT 2
- Bump bin-version-check dep version HOT 2
- dest() affects the success of run() finding a binary
- Allow specifying a checksum of the bin
- Be able to download the app without running it
- High security vulnerability reported due to dependency on decompress HOT 3
- What are valid values for `arch`? HOT 1
- This package needs a new maintainer - or an archive-flag HOT 11
- Outdated `bin-version-check` dependency - needs version bumping HOT 2
- Outdated download dependency - needs version bumping
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bin-wrapper.