Code Monkey home page Code Monkey logo

inline-comments's People

Contributors

christianwach avatar fvmartin avatar herdo avatar kevinweber avatar r-a-y avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

inline-comments's Issues

Selection (in JS) for empty elements

I have the a post as shown on the image below:
grafik

As Selectors I have defined .entry-content p - nothing else.
Asy you can see, the comment bubbles are correctly generated for empty paragraphs.

I searched for a solution, but I was unable to find a pure CSS solution to solve this problem.
Would it be possible to hook into the bubble generation in JS (maybe with an additional option for the settings, or always enabled), to exclude the bubble generation for elements that match the selectors, but are empty?

comments bubble not appearing when comment present

I implemented this plugin to my WordPress site, using the selector .entry-content p.

The comment bubble appears for each paragraph on hover. However, once a comment is posted, the bubble with comment count does not appear. The comment save, I can see them in the backend, however, the plugin just doesn't recognize that a comment exists. I've also implemented WP Ajaxify comments.

Is there a way to fix this?

Undefined variable in inline-comments.min.js

Someone asked me to fix their wordpress page. I get undefined variables from inline-comments.

This is the specific subsection of minified javascript code: (inline-comments.min.js)
i is undefined as shown in error below. thanks.
l=function(){var n,e,o;for(n=t(i.selectors),e=0,o=n.length;e<o;e+=1)

    l https://ipinionsyndicate.com/wp-content/plugins/inline-comments/js/min/inline-comments.min.js?ver=2.3:1
    rebuild https://ipinionsyndicate.com/wp-content/plugins/inline-comments/js/min/inline-comments.min.js?ver=2.3:1
    icTimer https://ipinionsyndicate.com/:1874
    setTimeout handler* https://ipinionsyndicate.com/:1873
    jQuery 9
    <anonymous> https://ipinionsyndicate.com/:1763
    jQuery 11
inline-comments.min.js:1:815
    l https://ipinionsyndicate.com/wp-content/plugins/inline-comments/js/min/inline-comments.min.js?ver=2.3:1
    rebuild https://ipinionsyndicate.com/wp-content/plugins/inline-comments/js/min/inline-comments.min.js?ver=2.3:1
    icTimer https://ipinionsyndicate.com/:1874
    (Async: setTimeout handler)
    <anonymous> https://ipinionsyndicate.com/:1873
    jQuery 9
    <anonymous> https://ipinionsyndicate.com/:1763
    jQuery 11

Negative selectors

Not sure where you would like feature requests, but it would be handy if the selectors section could use negative selectors.

If it can do this, I seem to be struggling.

Use case, is display inline commenting on all pages, except a page with a certain tag for example.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.