Code Monkey home page Code Monkey logo

Comments (9)

KevinBatdorf avatar KevinBatdorf commented on September 17, 2024

Why not? It's a dependency and if I don't include it than a majority of the people downloading it will not understand it. 1) I get enough emails a day asking how to implement it and 2) I often see jQuery in repos here.

from liquidslider.

Ocramius avatar Ocramius commented on September 17, 2024

@KevinBatdorf gotcha. I'm used to including them via package managers, but I can understand what the target person who downloads this lib is.

from liquidslider.

KevinBatdorf avatar KevinBatdorf commented on September 17, 2024

Ah, I see where you're coming from now. Today I got an email asking how to center the slider on the page, so I try to make things as simple as possible :P

from liquidslider.

Ocramius avatar Ocramius commented on September 17, 2024

Yep, totally different approach ;)

Just imagine if I told my designers to use something like yeoman to bootstrap a project: "boot-what?!"

from liquidslider.

Flobin avatar Flobin commented on September 17, 2024

One argument for removing jQuery from liquidslider is that while jQuery is currently bundled with Liquidslider, it's an outdated version (1.8.2). If you remove it from liquidslider, people will link to or put it in it themselves, ensuring they use the latest version.

Actually, a better solution may be to just include the latest version.

from liquidslider.

KevinBatdorf avatar KevinBatdorf commented on September 17, 2024

Good call, I updated to the most recent.

from liquidslider.

KevinBatdorf avatar KevinBatdorf commented on September 17, 2024

In case someone reads this later, I ended up removing jQuery and putting a link to the CDN inside the demo. That makes more sense anyway, I think.

from liquidslider.

Flobin avatar Flobin commented on September 17, 2024

That actually makes more sense. It'll probably be much faster, too.

from liquidslider.

Ocramius avatar Ocramius commented on September 17, 2024

@KevinBatdorf thank you :)

from liquidslider.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.