Code Monkey home page Code Monkey logo

Comments (8)

KevinBatdorf avatar KevinBatdorf commented on August 15, 2024

On mobile, when u switch to portrait the final time, does the navigation still work (even as tabs) ? Does it look funky?

Both issues sound like browser problems that I doubt I'll be able to address. Also, the typical user won't likely switch back and forth like that, and rarely will a user be adjusting their browser like that. it might not be a huge concern.

However, does this happen on the demo site too? I cant reproduce the arrows breaking. Does it happen consistently?

from liquidslider.

rusticguy avatar rusticguy commented on August 15, 2024

Yes the TAB works fine and it does look funky because there isn't much space available to fit all TABS.
As for resizing the browser, that was just a test which is normally applied for testing responsiveness. The arrows breaking happens very consistently every time it is tried. Yes it happens on http://liquidslider.kevinbatdorf.com/ also wrt arrow breaking navigation breaking by doing a browser resizing after reducing the width down to mobile width.

from liquidslider.

KevinBatdorf avatar KevinBatdorf commented on August 15, 2024

Your best bet is to style the tabs as a backup in case the navigation type doesn't switch over as expected. You could make each tab full width, and use jQuery to hide them if you have too many tabs.

I see the problem with the arrows, and i'll have to figure out what's going on. I'll get back to you here in a day or two.

from liquidslider.

rusticguy avatar rusticguy commented on August 15, 2024

Ok i will try something on this. The issue of navigation apparently looks to be happening other way round also. There are times when the mobile menu (fixed at < 481px) is carried over to > 481 also on orientation change. So the select menu is visible many a times when TABS should be visible (landscape mode). Most of the time a TAP at address bar to type something and getting back to screen without doing anything gets the correct menu back without any change of orientation which again gets messed up on change of orientation.

from liquidslider.

KevinBatdorf avatar KevinBatdorf commented on August 15, 2024

ha ha, can't catch a break can we?? I guess if you feel your users will be moving your site around a lot, you can just disable the mobile nav all together.

I'll look into ways to address this, but these mobile browsers are pretty funky. I could perhaps put some sort of double check in place.

from liquidslider.

rusticguy avatar rusticguy commented on August 15, 2024

Sorry to bother you. Normally this is how we test for breakpoints (doing a more than once orientation change). I am not sure if the check of orientation could be built into code to force a particular menu and see if that can fix this issue.

from liquidslider.

KevinBatdorf avatar KevinBatdorf commented on August 15, 2024

You're not bothering me, you identified a couple of key things I need to address. So i owe you a thanks! Yeah, we use it for testing, but it's unlikely that a user will be doing the same. However, if it can be fixed, it should be. I'll look into orientation check, but I imagine it would occur at the same time as the width change, and would thus would also not apply. I'll toy around with a 1 second timeout to reapply the styling in case the browser doesn't.

All that's going on is one nav style is being hidden, while the other unhidden. There's no reason is shouldnt be working, except for browsers not behaving as you would expect them to.

from liquidslider.

rusticguy avatar rusticguy commented on August 15, 2024

This is fixed. Thanks

from liquidslider.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.