Code Monkey home page Code Monkey logo

Comments (6)

gctucker avatar gctucker commented on August 13, 2024

There are some potential issues with this:

  • some labs don't have a public LAVA web UI, so there can't be public links to these jobs
  • some old jobs may be archived after a while, I know we do this on the Collabora LAVA server

So there could be a "best effort" URL if that helps, which might cause people to report problems if it doesn't work. Maybe we could just show the LAVA job number, so if you have access to the lab (public or not) then you can trace it back.

from kernelci-core.

broonie avatar broonie commented on August 13, 2024

We could always have a flag for each lab which says if the web UI is public and only generates a link if that's the case - show the job number always and make it a link if the UI is there. I do think we should use a link if we can, it's an obvious thing to do and people will wonder why it's not a link in cases where it's useful.

Given that we don't keep much history on the KernelCI server I'm not sure jobs getting archived is a pressing issue, I suspect the jobs will vanish from KernelCI before the labs.

from kernelci-core.

gctucker avatar gctucker commented on August 13, 2024

True, jobs are only available for a few weeks on kernelci.org.

There's the labs.ini file in kernelci-core, we could add a flag there to enable jobs URLs or not.

We could also check that the URL is valid and available when receiving a LAVA callback in the backend, to automatically determine if it should be featured on the frontend.

from kernelci-core.

broonie avatar broonie commented on August 13, 2024

I thought about checking at submission time if the link works but I thought that might give false positives in cases where the lab has a firewall or other access configuration that gives the master server access but not random internet addresses.

from kernelci-core.

danrue avatar danrue commented on August 13, 2024

One other issue is that job ids aren't necessarily unique; I know @mattface will delete the database and start over occasionally, which would cause links to go to incorrect jobs over time. Makes me wonder if LAVA should use something more unique than a sequential ID for jobs...

from kernelci-core.

broonie avatar broonie commented on August 13, 2024

With the short history you'd need to be deleting the database pretty often to hit any actual collisions I guess?

from kernelci-core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.