query with onlyNER=true returns an entity without type about entity-fishing HOT 11 CLOSED

So the issue is generated by the acronyms in particular when the onlyNER is selected the NER process is executed and socialiste-revolutionaire is not found by the NER engine.

In the following step the acronyms are injected in the list:

// inject explicit acronyms
entities = ProcessText.acronymCandidates(nerdQuery, entities);

They have indeed no type as they are not NER entities.

@kermitt2 does it make sense to have the acronym mixed with the NER when the query is executed having onlyNER: true?

from entity-fishing.

I will check this one because in branch 0.0.3, I've modified the mention, acronym stuff and removed the onlyNER option.
(normally acronyms are not mixed anymore with NER mention)

from entity-fishing.

I'm checking this, from what I can understand the acronym are always processed independently from the mention recognition.

Shouldn't they be separated from the mention recognition? Or at least be flagged as acronym in the output?

from entity-fishing.

What also about having back some flag that disable the disambiguation and provide only mentions?

from entity-fishing.

I don't understand the question on acronyms... but we could flag entities which are recognized as acronyms, the issue is when we have an acronym not introduced in the input text - this is not an information we get from wikidata/wikipedia only

providing only mentions -> this tool is focusing on entity disambiguation, I would say if users are only interested in mentions, they could just use the external modules for this (grobid-ner, etc.). The other problem is that users don't want just mentions in general, they want also entity classes (person, species, astronomical object, etc.), which is ultimately relying on WikiData here, so on disambiguation...

from entity-fishing.

My question about acronyms is based on the example whether flagging the entities recognised as Acronym could be a solution to provide some more information to the client.
What do you mean with acronym not introduced in the input text? Something like [...]blablabla Do it Yourself blablabla[...] recognise Do It Yourself as DIY?

Regarding the mentions, indeed users can do use other tools, but grobid-ner for example doesn't have any API, well entity-fishing was supposed to be one kermitt2/grobid-ner#56 (comment).

When I say mention, I say mention+attributes based on the method used: so for example you could recognise mentions from ner and the NE class and mention from wikipedia without any NE class.
Actually the option could be just disambiguate: false to disable it.

from entity-fishing.

Regarding the option onlyNER for backward compatibility I think is a better practice to add back the option in the API but marking it as deprecated, which will be removed in the following release.

from entity-fishing.

The use of "onlyNER": true cannot be handled by Pdf text

from entity-fishing.

1. check documentation
2. working only for text, not working on PDF
3. working only for en and fr
4. if set = true make sure the disambiguation is disabled

from entity-fishing.

The test for this issue was done as follows:

1. Test case: check documentation whether handle the onlyNER issue or not.

• check the option onlyNER exists in Nerd's documentation
• Result: Pass

2. Test case: check whether onlyNER works only for the text and not for PDF files

• for the text

• Result: Pass

3. Test case: check whether onlyNER works only for EN and FR (since it use Grobid-Ner which works currently just for English and French)

• onlyNER for English language

• onlyNER for Italian language

• Result: Pass

4. Test case: If onlyNER is set into TRUE, the disambiguation is disabled

• onlyNER is set into true will result the mention Paul von Hindenburg as Paul and von Hindenburg

• onlyNER is not set will raise the ambiguation result as a full Paul von Hindenburg mention.

• Result: Pass

from entity-fishing.

Conclusion: this issue is closed with the reason that all the test cases given are met and passed.

from entity-fishing.