Comments (13)
Yeah, that was one of the issues I opened and closed a few months ago due to me thinking it was my eye trolling me.
I will take a look at the circle building code but I am not sure if I get a good idea of how to optimize prubys code.
from shape-builder.
Me neither, it works really well, and I can't figure out where it's going "wrong"
from shape-builder.
I finally have computercraft again do I will try one thing I thought of.
from shape-builder.
got this: http://pastebin.com/JH3ATidy from marvintpa in the CC forums, how shall we implement it?, replace prubys code?
from shape-builder.
I don't have time to test it. How does it handle speedwise and shape wise to pruby's code?
from shape-builder.
Gonna run a few test builds tomorrow... will post the results here.
from shape-builder.
Hm, gonna upload a few screenshots here. Left is the older code, right sphere the new one. the smaller circles look way better than prubys code and imo even the bigger ones look a bit less than octagons.
The spheres actually have the same diameter: 25 blocks, but since the sides are not as flat the new code's spheres looks smaller
from shape-builder.
That is a ton of waypoints, wow. How did they compare speed-wise? I'm going to guess that it was faster. It looks like they also used less material too.
from shape-builder.
Did not check the speed on them, I think he pretty much modified the whole code to work like the rest of our program does, A quick peek into it made it look like it is building pretty much like the old code was, so it should be comparable in speed. He did a good job in incorporating the methods into our program. Should be resumable and support all other features of the versatile shape builder.
from shape-builder.
I think that we should implement it then!
from shape-builder.
implemented it, just one last bug to fix, it builds it one row too high
/edit: that is fixed. Now another bug, please look into it, i was not able to fix it o.O: the spheres and circles are built one block too far in the x and y direction, basically shifted.
from shape-builder.
weird, I'll look into it.
from shape-builder.
Marking as closed since we've implemented code that fixes this. This issue can still be a journal / discussion if we need it.
from shape-builder.
Related Issues (20)
- linktorssstation on line 1505 is wrong method name? HOT 1
- Enhancement: Add circular platforms. HOT 7
- Minor: "offset" is miss-spelled in a few places, not breaking
- getInput
- resupply module bugs
- Revamp Choicefunction
- Enderchest refilling HOT 2
- Build:982: attempt to index ? (a nil value) HOT 1
- Non straight line HOT 6
- 8-Prism doesn't work
- Extra movement in pastebin code HOT 2
- Hexagon Code is Broken: Suggest Removing that Shape. HOT 2
- Typo, choiceIsValidShape, shphere HOT 2
- State flags aren't stored in the restore table.
- Pastebin link is old and contains some shape breaking code. HOT 2
- Porting to OpenComputers HOT 3
- Torus? HOT 3
- Display progress on build
- Restructure code to be more organized HOT 1
- Improved Command Line Arguments? HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from shape-builder.