Please avoid directly commit to master about algorithms HOT 6 CLOSED

@goswami-rahul @SaadBenn @danghai
Maybe we should mention this in the CONTRIBUTING.md . And should this file link in the README.md. Right away in the head. Good practice is creating a separate branch for each issue.
What we mention in the CONTRUBUTIUNG too that each new algorithm/data structure should be tested. Today I found a project (rsa.py) that was buggy. And some others ... I fixed it. But this should not be!

from algorithms.

It was my mistake, I'll be careful next time.

from algorithms.

@SaadBenn
Please do not commit with the general name (Ex: Update README.md). Writing a good specific commit makes other people easy to follow and know what you do in your commit. It also helps people keep track of information about these commit later when they want to review

from algorithms.

I'll make sure of that. @danghai

from algorithms.

I was thinking that we are making one too many commits for each algorithm or test that we submit. Is it possible to squash it to maybe just a single commit/ file unless the commit is very specific then in that case we can have that. Another issue that I found was that our git history is very non-linear. There is a lot of bubbles in our git history which makes it impossible to follow. The solution is very simple: Once we create a branch and make our changes, all we need to do is rebase our branch against the local master and once we have that then we can push our changes from the local master to the repo's master. That way our history would become linear and much more elegant.
Here is how to do it:
git rebase master
git checkout master
git merge local_branch
and always do git pull --rebase
These are just my two cents tho.

from algorithms.

@goswami-rahul @christianbender @danghai @SaadBenn
I agree with @SaadBenn . If possible please squash the commits so that it is easier to see what individual commits are for.
I'll close the issue.

from algorithms.