Bug with Acronym? about match-sorter HOT 8 CLOSED

Additionally, "sa" will match "Aland Islands", and "as" will match "Australia" and "Austria".

from match-sorter.

Interesting. I'm not sure what's up.

I'm afraid that I'm not actively using this package so I don't have any time to dedicate to figuring out what the issue is. If you do find what the problem is I welcome you to make a pull request to fix it.

from match-sorter.

Gotcha. Since I'm not a JS dev and also have very limited time, I'll leave this for someone else.

from match-sorter.

I believe this issue is stemming from the use of >= in reduceItemsToRanked() paired with getRanking() found in getClosenessRanking()

function getRanking(spread) {
    const matching = spread - stringToRank.length + 1;
    const ranking = rankings.MATCHES + 1 / matching
    return ranking
}

This function will, in certain cases as mentioned above, return 2 which when compared to the acronym threshold will return the item.

from match-sorter.

Thanks Steven,

Any chance you could make a PR with a failing test first so I can see how this bug plays out in a practical scenario?

from match-sorter.

Thanks to @sdbrannum for fixing this!

from match-sorter.

@all-contributors please add @cmeeren for bugs

from match-sorter.

@kentcdodds

I've put up a pull request to add @cmeeren! 🎉

from match-sorter.