How to identify a macros about babel-plugin-macros HOT 14 CLOSED

Yeah, I think that we should probably only have one (macro) and stick with that... Otherwise it will make things confusing.

from babel-plugin-macros.

This kind of really doesn't matter, but...

import css from "glam.macros"

Using "macros" (the plural) is kinda weird since that file only exports one macro.
Should we consider maybe doing .macro?

from babel-plugin-macros.

Yes, I'll make that change right now. Thanks!

from babel-plugin-macros.

I find it very unlikely that something like this would make it to the TC39 ever (I don't even know how that'd work) because it's a compile-time thing

I guess the ecosystem need something named CT39 - Compile-Time 39
😁

from babel-plugin-macros.

I guess let’s go with .macros naming for now and revisit after we have real world feedback from using it.

from babel-plugin-macros.

Sounds fine to me. I expect that if it's changed we could write a codemod to upgrade people's code in a pretty straightforward way anyway 😄

Still open to other thoughts though!

from babel-plugin-macros.

I'd say I'd like to stay away from having to handle new syntax in Babel itself? Although we made exceptions in the past for JSX/Flow/TS and same with proposals - we aren't adding anything if it's not proposed to TC39?

from babel-plugin-macros.

Sounds good. I think the best way forward is to continue as we are. I find it very unlikely that something like this would make it to the TC39 ever (I don't even know how that'd work) because it's a compile-time thing. We'll see what the future holds. Thanks for the input @hzoo!

from babel-plugin-macros.

Going to go ahead and close this for now. Happy to hear other thoughts though.

from babel-plugin-macros.

Done. Thanks again! 👍 v0.5.0

from babel-plugin-macros.

What if there're more macros?

import { Translation, Plural, Select } from 'i18n.macros'

I guess it could be written on separate lines, but it's just shorter/faster.

from babel-plugin-macros.

What you have there is totally supported (except the source must end in macro). See this and this.

Though that's a good point. Perhaps we should support both macro and macros?

from babel-plugin-macros.

I really don't mind about naming, whatever works. Let's stick to macro ;) I thought I read through test cases, but I definitely missed that.

Awesome work!

from babel-plugin-macros.

I don't see too much of an issue supporting both macro and macros. Only downside I can think of would be documentation/learning overhead.

from babel-plugin-macros.