Comments (7)
I have added healthchecks_url as a setting. It allows you to override the URL. I have updated the github version, but I have not yet updated the version on PyPI. Please check this version and let me know if it meets your needs. Once it seems okay, I will update PyPI.
from emborg.
Had a go with this and can't seem to get it to work. My hosted healthchecks URL is:
https://healthchecks.gently.org.uk:7000/ping/0b0c6bc2-3894-4039-b3ad-3660f35e45ab
I've set:
healthchecks_url = 'https://healthchecks.gently.org.uk:7000/ping/'
healthchecks_uuid = '0b0c6bc2-3894-4039-b3ad-3660f35e45ab'
However, it doesn't seem to be working. I've checked that I can run 'curl https://healthchecks.gently.org.uk:7000/ping/0b0c6bc2-3894-4039-b3ad-3660f35e45ab' and this seems to work Ok.
Is there any debugging I can enable to see what URL emborg is using to notify healthchecks?
from emborg.
Think I've found an error. The signalling of the completion is:
url = f'{self.URL}/{self.uuid}/{status}'
it should be
url = f'{self.url}/{self.uuid}/{status}'
The signalling of 'start' appears to be correct. It also appears that the trailing '/' on the 'healthchecks_url' might have been causing an issue. I've changed the code as above and it seems to be working now.
from emborg.
One other suggestion, when logging in these sections, it might be more helpful to log the full url used (the local url
variable) instead of just the UUID.
from emborg.
Sorry about that. I think I have fixed the issues you identified. Logging the url is a good idea, and probably would have resulting in me finding the problem before I committed it. Thanks for you help in identifying my mistake.
from emborg.
No problem, we all make mistakes! Happy to help.
Tested and appears to be working. Look forward to seeing an 'official' release, will update the Alpine package when it happens.
from emborg.
Latest version is now on PyPI. Thanks for your suggestions and help.
from emborg.
Related Issues (20)
- Healthchecks 'success' not sent when borg returns 1 (which is only a warning) HOT 11
- Unable to run tests in 1.29 HOT 8
- Clearer explanation of "working_dir" and paths? HOT 2
- run_after_last_backup may sometimes run too soon HOT 5
- Support for 'borg compact' HOT 3
- "emborg --narrate create" with "check_after_create = 'latest'" prints entire output of "borg list" to stdout HOT 4
- Support for borg create --upload-ratelimit in borg 1.2 HOT 2
- compact_after_delete generates error HOT 6
- Occasional test failures HOT 1
- Add support for 'recreate' HOT 3
- Tests fail on v1.33 with borg 1.2.2 HOT 4
- Tests not runnable on case-insensitive systems HOT 3
- Composite create fails HOT 2
- Tests fail on v1.36 HOT 4
- nestedtext new dependency HOT 2
- Dry run option doesn't work for `emborg check --repair` HOT 2
- Somewhere along the line emborg stopped posting to healthchecks.io HOT 3
- Recommended install with new pip limitations HOT 5
- Default config uses notify-send which is not mentioned in dependencies or installation instructions HOT 3
- Last backup stats not recorded correctly. HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from emborg.