Improve host settings about kellnr HOT 4 CLOSED

I’m confused about why Kellnr needs to be aware of the “External” hostname, port, and protocol. I think it’s usually the responsibility of something like a proxy in front of Kellnr.

from kellnr.

Yeah that seems strange at first, but it is required due to the way that the protocol works.

Example:

You run Kellnr on a Server with the IP 1.2.3.4 on port 80. Now, you put a reverse proxy in front of it to serve it with from "kellnr.mycompany.com" on port 443 with TLS.

Next, you configure Cargo to use "kellnr.mycompany.com:443" as a registry. What Cargo does now is a bit strange: It request a specific route on Kellnr (or any other registry) to get a "config.json".

The json looks like this:

{
    dl: String,
    api: String,
    auth_required: bool,
}

dl and api are the host, where Cargo will try to pull crates from, in our case this needs to be "kellnr.mycompany.com:443" (the proxy address) and not the host that Kellnr runs on. That's why Kellnr needs to know, where it is reachable from the "outside" to be able to fill the "config.json" correctly.

I hope this explains, why Kellnr needs to know the "external" host.

from kellnr.

Thank you, @secana.
I believe I understand now.
So, the index address written in .cargo/config.toml and the address of the server that eventually serves the crates could be different.
Kellnr manages both sides and aims to hide the complexity of these.

For me, instead of "External", using "Server" might be more understandable in this situation.

from kellnr.

Complete refactoring of settings finished

from kellnr.