Code Monkey home page Code Monkey logo

Comments (21)

GittiHab avatar GittiHab commented on September 23, 2024 1

I have added a documentation on Travis/Docker for the future https://github.com/KDD-OpenSource/32de-python/wiki/Continuous-Integration-and-Docker

from 32de-python.

Baschdl avatar Baschdl commented on September 23, 2024

Could you please describe your problems further?

from 32de-python.

Baschdl avatar Baschdl commented on September 23, 2024

@GittiHab Please talk with us πŸ˜‰ We would save time if we wouldn't test the exact same things repeatedly like using directly travis without Docker, this won't work because travis uses a Ubuntu version where graph-tool is broken.

from 32de-python.

GittiHab avatar GittiHab commented on September 23, 2024

@Baschdl Following the instructions on the Python Coveralls module it turns out that it expects to be run directly in Travis – that's why I just wanted to try that out but, as you pointed out, graph-tool doesn't like that. If you like, you can look into the error log on Travis before I removed the docker part.

from 32de-python.

GittiHab avatar GittiHab commented on September 23, 2024

Trying to talk to you is exactly what I have been trying to do by opening this issue. (I didn't expect you to work on this Fridays, anyways)

from 32de-python.

GittiHab avatar GittiHab commented on September 23, 2024

This Travis build is especially helpful. Of course, you can probably test it locally but I have been having trouble there, too.

There is probably some solution somehow but I am not sure if it's worth it.

from 32de-python.

Baschdl avatar Baschdl commented on September 23, 2024

"Friday is burger day" (@WGierke) so it would be a shame to not work today 😁 Isn't z4r/python-coveralls#59 a promising issue for our problem?

from 32de-python.

GittiHab avatar GittiHab commented on September 23, 2024

@Baschdl work yes, but on this? Seems to be promising. But I have already invested enough time on this today, I actually planned on doing other things. Maybe you can take a look and make Travis happy again πŸ˜‰ (I really hate GitHubs emoji support where you have to know the names of them)

from 32de-python.

Baschdl avatar Baschdl commented on September 23, 2024

I probably also have no time for this today

from 32de-python.

WGierke avatar WGierke commented on September 23, 2024

I also planned on having a nice Friday burger with some friends today but life isn't always a bowl of cherries.

from 32de-python.

GittiHab avatar GittiHab commented on September 23, 2024

Runs locally... but not on Travis.

from 32de-python.

GittiHab avatar GittiHab commented on September 23, 2024

It seems that the .coverage file contains the wrong paths (the ones from docker not travis). Maybe coverage combine works differently with python 3.6. This should be debugged.

from 32de-python.

Baschdl avatar Baschdl commented on September 23, 2024

The first idea for debugging is to print the file on travis with cat.

from 32de-python.

GittiHab avatar GittiHab commented on September 23, 2024

Sadly, this didn't tell us anything new. Link to Travis build

from 32de-python.

Baschdl avatar Baschdl commented on September 23, 2024

Travis goes into the 32de-python-folder by running cd KDD-OpenSource/32de-python when running git clone --depth=50 --branch=coveralls https://github.com/KDD-OpenSource/32de-python.git KDD-OpenSource/32de-python. So it can't find the python file in /32de-python/active_learning/__init__.py because this file is in active_learning/__init__.py.

from 32de-python.

GittiHab avatar GittiHab commented on September 23, 2024

The path prefix /32de-python/... comes from Docker as this is the absolute path to the file in the container. Whereas in Travis the absolute path to the file would be /OpenSource/32de-python/...

from 32de-python.

Baschdl avatar Baschdl commented on September 23, 2024

But it would be sufficient to use the relative path ... (in your example), so for example active_learning/__init__.py and everything would be fixed?

from 32de-python.

GittiHab avatar GittiHab commented on September 23, 2024

I am not the one specifying the path – it is the coverage module of python doing it. I indeed specified a relative path in .coveragerc that should be used when merging .coverage file (these are the generated one with the absolute path). This is also what it does locally which is why it works locally.

from 32de-python.

GittiHab avatar GittiHab commented on September 23, 2024

OK, I manually replaced it now... that "fixes" the issue.

from 32de-python.

GittiHab avatar GittiHab commented on September 23, 2024

GitHub doesn't seem to have noticed that the PR solved this.

from 32de-python.

Baschdl avatar Baschdl commented on September 23, 2024

Nice work :D

from 32de-python.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.