Close parens on indented line about vsc-python-indent HOT 6 CLOSED

Re your first comment, yes, that would be my preference.

Re #65, I would consider them separate issues personally. Solving #65 would be nice, but isn't a big deal to my mind as you just need to enter another tab when starting to define the function arguments.

from vsc-python-indent.

Hi @tclose, there is a new option (keepHangingBracketOnLine) available in v1.11.0 of the extension for this behavior. Please note that I bumped the required version of VSCode to the most recent, so you'll have to be on an up-to-date VSCode to update the extension.

If you have problems, please submit a new issue.

from vsc-python-indent.

Hey @tclose, thanks for submitting an issue.

Right now the code makes no distinction between function calls and other kinds of brackets (()[]{} are all treated the same). Would you be ok with the setting also changing the following behavior?

variable = [|]
# goes to...
variable = [
    |]

from vsc-python-indent.

This is actually related to #65 I think. If such an option were added, then we'd have to do more parsing to figure out if we were in the middle of an indent-increasing section so that we could add an extra level of indentation per PEP8. Examples adapted from PEP8:

# Add 4 spaces (an extra level of indentation) to distinguish arguments from the rest
# (the next set of lines will be at a higher level of indentation).
def long_function_name(
        var_one, var_two, var_three,
        var_four):
    print(var_one)

# Do NOT add 4 extra spaces
# (the next set of lines will be at the same level of indentation).
foo = long_function_name(
    var_one, var_two,
    var_three, var_four)

# Relatedly, I think we'd want to do similar behavior for things like "if"
if (
        x in my_first_list_maker(arg1, arg2)
        + my_second_list_maker(arg3, arg4)):
    print(x)

from vsc-python-indent.

from vsc-python-indent.

I cannot believe I am just discovering this setting now (because I've been using the extension pretty much since inception). But thank you! It's a game-changer for me.

from vsc-python-indent.