Extension is not activated with highlighted text and pressing ENTER about vsc-python-indent HOT 7 CLOSED

Good use case, good write up. Thanks for the issue!

I specifically have the extension set to not run when there is text highlighted (see the !editorHasSelection portion), but to be honest I don't remember why. Maybe it doesn't delete the highlighted text if my extension runs in that case?

I imagine most of the time spent on this issue will be trying to figure out what poor behaviors come from allowing it to run when text is highlighted, and how to mitigate them.

from vsc-python-indent.

Minor nitpick, shouldn't the desired behavior be

my_dict = {'a': 1,
           'b': 2}
# No trailing space and code is aligned

instead of

my_dict = {'a': 1,
                  'b': 2}
# No trailing space and code is aligned

?

from vsc-python-indent.

Yikes! That is NOT how it looked when I submitted or previewed it. Now when I go to edit it, I have to take off spaces and check the preview to make sure it's aligned. The two views are not the same! Very strange. I guess I'm going to have to double-check the post after posting too.

from vsc-python-indent.

I'm surprised you didn't document that. Your documentation is very thorough.

I specifically have the extension set to not run when there is text highlighted

I can change that setting in my package.json for your extension and test it out and provide feedback.

I think the reason my alignment for the code was off is because the font is not fixed-width. Any idea how to change that? It should be a GitHub setting now a browser one.

from vsc-python-indent.

OK after removing !editorHasSelection and !editorHasMultipleSelections from lines 32 and 37 of package.json, the space from the beginning of the selection on the first line to the end of the selection on the new line is still highlighted.

The pipes and dots in between represent the highlighted section:

my_dict = {'a': 1,|
..........|'b': 2}

from vsc-python-indent.

It turns out the selected text wasn't even being deleted (since the extension was now responsible for doing it). All that was needed was 4 lines of code at the beginning to delete the selection first. I submitted a pull request.

from vsc-python-indent.

This should now work correctly in version 1.1.0. Please upgrade and re-open if the issue persists.

from vsc-python-indent.