Support right-to-left languages about codeflask HOT 13 CLOSED

@kazzkiq That's what I was mentioning too. I might be able to write something up that includes both allowing people to select the RTL mode on runtime when running the editor and also some JS code that listens to the changes to the textarea text-align css property that changes the placeholder one as well.

from codeflask.

@AndreYonadam

We need this mostly with Markdown

it's working

thank you

from codeflask.

Interesting. I got somewhere but right clicking on the textfield and clicking the following to change the direction of the writing. This was in Chrome.

However the overlay was still doing left to right so I'm assuming there is a way to do that also using CSS.

from codeflask.

How's it going @MajidCS . What are the symptoms you are exhibiting when using RTL other than the overlay is not on the correct side?

from codeflask.

I think I might know the first for this. I will probably get to it sometime in the next few days.

from codeflask.

Just as a heads up. Safari also has a feature that allows setting the text direction as shown below.

If you want to change the direction to RTL I've found that all you have to do is add a direction property with rtl as the css value to the container that holds both the textarea and the span elements.

from codeflask.

A quick text-align: right on .CodeFlask__textarea and .CodeFlask__code should do most of the job.

The problem is that indentation should also get handled properly on RTL mode (which means there would be changes on JS as well as CSS). I believe this should be added as an option to .run()/.runAll() functions. Something like:

const flask = new CodeFlask;
flask.run('#editor', {language: 'javascript', rtl: true}) // add rlt functionality

from codeflask.

@AndreYonadam awesome! Once you move forward with the code, or if you get in any trouble, please let us know.

from codeflask.

Pull request #28 fixes all these features just as described.

from codeflask.

@AndreYonadam @kazzkiq Thanks guys

from codeflask.

@MajidCS Sure thing. I've been working on it but it seems that it's not producing an idea result. I'm not really familiar with how it's supposed to work but it seems like it's a limitation for all textareas when in RTL mode. Check the gif @kazzkiq has posted in #28 . We're getting mis-formatting for some reason.

from codeflask.

@MajidCS Wow thanks for the testing. I wasn't able to test it because I didn't know what the expected output was. Thanks again.

from codeflask.

PR #28 fixes this.

from codeflask.