Handling node Buffer about jsonexport HOT 11 CLOSED

We have published code for this issue to become resolved. Please test and report back and/or close this issue.

Thank you in kind, in advanced

from jsonexport.

Unfortunatelly I went on a different direction and ended up using JSON.parse(JSON.stringify(data)) to convert all buffers to string. I wont be able to test this anywhere soon, but feel free to close this issue.

from jsonexport.

@Roger13 Maybe if you modify handleObject https://github.com/kauegimenes/jsonexport/blob/master/lib/parser/handler.js#L82
But currently this module does not support a custom object handler.

from jsonexport.

jsonexport(contacts, {
    handleObject: function(element, item, originalHandler){
        if (element instanceof Buffer) return [
            {item: element, 
            value: element.toString(),}
        ];
        return originalHandler(element, item);        
    }
}, function(err, csv){
    if(err) return console.log(err);
    console.log(csv);
});

Help wanted PR #49

from jsonexport.

@AckerApple What you think about this?
I think it's not nice to make the user return an array with item and value
also calling the originalHandler should be done by the module not the user.

from jsonexport.

really busy at the moment but @kauegimenes you know I love to pick apart code.

I will provide a response within maximum 48 hours

from jsonexport.

Thanks @AckerApple =) take your time!

from jsonexport.

I havent looked down this project source code yet, but since there isn't an 'handleObject' option yet, I could open a PR implementing it!

from jsonexport.

I put in some real time for this issue report which is now a feature request.

Please review #49 and my comments in it

@kauegimenes, I think it's going to be to your liking and our desired goal of simplicity. Merge if satisfied. Hit me up for more info

from jsonexport.

We will have a release for this relatively soon-isc. Most all work done

from jsonexport.

@Roger13 Please report back so we can close this issue.

from jsonexport.