Makefile missed DIR about kgt HOT 6 CLOSED

Hiya,

How do you reproduce the error, please?

from kgt.

Just download a fresh kgt-master.zip from github. Install the essential mk in share directory.
make or bmake in kgt-master.
some error:
ld -r -o build/lib/bnf.o build/src/bnf/lexer.o build/src/bnf/parser.o build/src/bnf/output.o
ld: cannot open output file build/lib/bnf.o: No such file or directory

Because the makefile not create a build/lib directory, the bnf.o cannot be created.

from kgt.

Can you reproduce this error when you check out the source by git recursively?

git clone --recursive https://github.com/katef/kgt

from kgt.

when using git clone --recursive https://github.com/katef/kgt,
the error will disappear, so, some of the makefile in somewhere patched the hole.
I think it is not a very serious bug. Only when someone just download the zip file without using the git, like browser only, will be compiled any more. The bug did not exist at my last download version. the old version makefile has this :

# TODO: centralise
#DIR += ${BUILD}/bin
DIR += ${BUILD}/lib

new makefile at the root no more,
I think some makefile make the directory build/lib for the bnf.o to save.
Sorry to make so much trouble.

from kgt.

You're not making trouble! Thank you for the bug reports :)

I think I should document that downloading a .zip from github isn't suitable, because these repositories use submodules. I hadn't thought of people doing that at all, and I appreciate the feedback.

from kgt.

I'm going to call this git's bug: dear-github/dear-github#214

from kgt.