Code Monkey home page Code Monkey logo

Comments (5)

seabbs avatar seabbs commented on May 30, 2024

Ah I see from your metadata you have in fact explored the variation over time - clearly need to check out your paper!

from nowcast-hub.

seabbs avatar seabbs commented on May 30, 2024

Bit hasty again I see you have explored nthreads

df85afd#diff-7ebb9d589758e49654f96070e578d174808be2d6cbabfbbb51fddefc22ab27c2

from nowcast-hub.

seabbs avatar seabbs commented on May 30, 2024

Also interesting to see how much better your approach begins to look vs others over time as I think most are truncating the reporting triangle quite a bit more than this (I'm truncating at 40 days for example so expect to underpredict long term).

value_80d = cbind(value_80d, `value_>80d`) %>% rowSums()) %>%

from nowcast-hub.

seabbs avatar seabbs commented on May 30, 2024

Wrapping up (😆) I'd be very interested to know how your method performs fit independently to each data stream (so to each age group and location).

In my work also been exploring hierarchical nowcasts (for age group) and annoyingly every permutation of model I have looked at so far has performed quite a lot worse than fitting independently. As coding myself I don't currently have access to splines so variation is via random effects and random walks and my findings could be down to a coding error.

Looking at my very preliminary evaluation of our methods I see some real outliers in certain states in terms of performance for your model. Obviously far far to early to tell and it could be you are just capturing very delayed reporting but potentially suggests your method may have the same issue as mine when it comes to independent vs joint fitting.

Evaluation of our methods
Evaluation of my model permuations (note the independent model outperforms all the others all of the time

from nowcast-hub.

kassteele avatar kassteele commented on May 30, 2024

Hi Sam, thanks! That's a lot to process. Here some replies:

  1. mgcv vs Stan: I also have some crude implementations of P-splines in Stan in this context, but I certainly agree that mgcv is much faster and more transparant.
  2. Yes, we considered calender time x delay interactions in our orignal paper (2019). However, the issue with such spline interactions is that extrapolations become very unstable. Hence, we had to apply several constraints. For the nowcast hub I try to keep it simple.
  3. Indeed I used nthread in bam, but for largers values, say >=4, it gave different results across different machines. Therefore I set nthreads = 1. That gave the same outcomes everywhere. You can imagine I got a bit worried before I figured that out...
  4. The raw reporting triangle data is truncated at 81 days. I am currently experimenting with truncating things to, say 40 - 50 days, just to see what is happening. We should not throw these delays away of course, but aggregate them in a >= 40 category. I am wondering if this would improve my fits, because now the RIVM model systematically overestimates the hospitalizations for 28 to ~7 days before the nowcast date.
  5. Have not tried that yet, but of course I could fit everything independently for each age group and location. Currently it is done by random effects (hierarchically or "shared parameters" so to say).
  6. So nice to see your evaluation in action. Yes, a few states do perform very badly! I will try to figure out what is going on there.

Again, thank you very much for you comments and suggestions!

Jan

from nowcast-hub.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.