NoMethodError: `private method 'load' called for nil:NilClass` about conventional_extensions HOT 4 CLOSED

@marcoroth thank you for trying out the gem and for the issue! Technically, you shouldn't need to call load_extensions manually in ActiveRecord::Base inheriting classes like in your repro.

But if you do, it should still work. I'll look over this because I want to make sure I understand it properly, thank you for the repro, it's very helpful.

from conventional_extensions.

After a second thought this might even be enough:

  def load_extensions(*extensions, from: Frame.previous.path)
-   @loader = Loader.new(self, from) unless loader_defined_before_entrance = defined?(@loader)
+   @loader = Loader.new(self, from) unless loader_defined_before_entrance = [email protected]?
    @loader.load(*extensions)
  ensure
    @loader = nil unless loader_defined_before_entrance
  end

from conventional_extensions.

@marcoroth I couldn't figure out how to reconcile the implementation with being able to support manually calling load_extensions for Active Records so I removed that feature.

I'll fix the other issue open and prep a new release.

from conventional_extensions.

Thanks @kaspth! I'm wondering if you actually needed to strip out that feature.

Maybe a warning or raising an error like "Calling load_extensions inside an ActiveRecord model is not necessary" would be enough if the class inherited from ActiveRecord::Base?

But either way, I appreciate you looking into it! 🙌🏼

from conventional_extensions.