create_and_save creates corrupted docx files on win32 platforms about htmltoword HOT 6 CLOSED

Have managed to develop a bug fix for this. Issue lies in
lib\htmltoword\document.rb line 14
replace

         File.open(file_path, "w") do |out|

with

        File.open(file_path, "wb") do |out| 

To ensure that files are written back in binary.
I'll try and issue a git pull request for this change,

from htmltoword.

Great!

from htmltoword.

Code merged into master. Closing issue.

from htmltoword.

In the Rubygem v0.4.4 - this bug has regressed back to the broken version, without the

File.open(file_path, "wb") do |out| 

It appears the document.rb in the gem is not the same as that on github, even if you point your Gemfile to github as in

gem 'htmltoword', :git => "https://github.com/karnov/htmltoword.git"

from htmltoword.

I just downloaded and unpacked the gem straight from rubygems, the create_and_save method does open the file with the wb options, maybe it's something else? I don't use windows, so it's a bit hard to debug 😕

from htmltoword.

I did the same as you, and yes, the extracted gem has the wb is correctly there. Did a bundle clean -force and reinstalled all gems from scratch, all seems to be ok now. Very odd. Closing call for the moment, unless I can repeat.

from htmltoword.