XML output misses contexts about karma-junit-reporter HOT 12 CLOSED

We're seeing this too. It's causing our Bamboo server to miss tests as many tests appear to be named the same in the generated junit xml file.

Downgraded to [email protected] for now as this doesn't exhibit this issue.

from karma-junit-reporter.

Same problem for us on Bamboo - with latest reporter version, out of 750 tests, Bamboo, after parsing, shows only 570 tests. With 2.2.2 Bamboo was showing a more realistic number (still not everything).

from karma-junit-reporter.

Thanks for the report

from karma-junit-reporter.

+1 would love to see a fix for this, or a tip on where to look if I were to try a PR ;)

from karma-junit-reporter.

I noticed this too after upgrading, the classname used in the XML is only the top level "describe" any nested "describe" names are omitted, so tests group under the one level instead of splitting out.

from karma-junit-reporter.

This error was introduced by e4f7ebd. In order to generate Sonar compatible report, one have changed generation of classname parameter from result.suite.join(' ') to result.suite[0].

from karma-junit-reporter.

Played with this locally and found that prefixing the test description with the parent suite names, ended it with the @osherx expected output test name.

From line #125

var spec = suites[browser.id].ele('testcase', {
  name: result.suite.join(' ') + ' ' + result.description, // was result.description
  time: ((result.time || 0) / 1000),
  classname: getClassName(browser, result)
})

I could possibly open a PR with that fix if @dignifiedquire thinks it looks good?

from karma-junit-reporter.

👍 for the idea of getting the nested describes working. We are also for now resorting to 0.3.3 downgrade most likely soon. I am writing a simple test for testing whether I could extinguish the bug; made by using that older working result.suite.join(' ') with enough sanity testing also so not to introduce new creepers. :) But so relative-newbie still (mostly in the tooling and philosophy of practical opensource) that I'll most likely be having a PR earliest 2016, if any.

from karma-junit-reporter.

@phillipj sorry for the late reply but yes that sounds good

from karma-junit-reporter.

Can this be tested by test suites within the reporter? Ie. does karma-junit-reporter itself have tests? I was also a bit hesitant in putting forward a blind PR.

from karma-junit-reporter.

@dignifiedquire Hi, has there been progress in this individual issue either through fix or the latest version containing changes? There's at least one pull request but the thing is that it should be tested with at least some known instances where the buggy 0.3.3 (-> onwards) name flattening happens. I didn't have test data at hand to test the PR.

from karma-junit-reporter.

+1

from karma-junit-reporter.