Comments (1)
just ran into this and was puzzled by the results; this is a serious bug...
I verified it's still there on master
here's a reduced case:
include karax / prelude
import sugar
var page = 2
proc createDom(): VNode = buildHtml(tdiv):
if page == 3:
tdiv: text "Some text v3"
# else: tdiv: text "Some text v2" # uncomment would remove bug
button(onclick=() => (echo "click 2"; page = 2)): text "2"
button(onclick=() => (echo "click 3"; page = 3)): text "3"
tdiv: text "Some text2: " & $page # removing `& $page` would remove bug
setRenderer createDom
click 3, then click 2: it should print:
click 3
click 2
but prints:
click 3
click 3
looks like dom diffing gets confused by the conditional inclusion of the node tdiv: text "Some text v3"
EDIT
just checked, this is actually a recent regression caused by e422087 /cc @Araq
- works in d08a035, both this example and the one in top post, so this bug had actually been fixed until it got broken again
- fails in e422087 avoid exponential DOM diffing
(although e422087 did help for another bug, as i had mentioned here e422087#commitcomment-35065660)
EDIT:
- adding
let recursive=true
right belowproc eq(a, b: VNode; recursive: bool): EqResult =
makes the bug go away; but that probably is bad for performance (maybe exponential complexity) - attaching a (unique)
id
on each button makes the bug go away; obviously this isn't desirable but could help debugging that issue; maybe what's going on is:
insidekarax.eq
, whenrecursive=false
, button 2 and button 3 might get confused; the even listeners are not compared (see# Do not test event listeners here!
); not sure how to compare them though, the naive way would likely just always return "different" even if comparing the same nodes
include karax / prelude
import sugar
var page = 2
proc createDom(): VNode = buildHtml(tdiv):
if page == 3:
tdiv: text "Some text v3"
# else: tdiv: text "Some text v2" # uncomment would remove bug
button(id = "id1", onclick=() => (echo "click 2"; page = 2)): text "2"
button(id = "id2", onclick=() => (echo "click 3"; page = 3)): text "3"
tdiv: text "Some text2: " & $page # removing `& $page` would remove bug
setRenderer createDom
from karax.
Related Issues (20)
- Wrong `app.js` directory (`karun`) HOT 1
- Delay in redrawing dom HOT 6
- buildHtml does not capture closure variables HOT 2
- Broken functionalities when karax used with grammarly or languagetool (and possibly other extensions) HOT 8
- How to run a function on onclick event in a button? HOT 4
- Boolean Attributes in DSL HOT 6
- Event example does not work HOT 8
- Release 1.2.3 HOT 5
- view doesn't update when changing state in setInterval HOT 3
- IndexDefect on array HOT 3
- Karax input text becoming null HOT 1
- Async karax? HOT 3
- Empty content editable raises an error HOT 1
- How to attach and detach a custom a `Node` to the karax dom? HOT 1
- Karax does not update event handlers HOT 4
- stack size exceeded error on js target HOT 1
- `verbitam` content is appended every time it changes HOT 1
- runtime error on redraw in `removeAllEventHandlers` proc HOT 2
- SVG rendering HOT 2
- 1.3.2 has a tag and release, but karax.nimble version still 1.3.1 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from karax.