vstyles setAttr not changing displayed VNode about karax HOT 7 OPEN

Yep, that's a bug. There are workarounds (like have the current color be a part of the id attribute) but those are a hack. To be honest I'm kind of surprised this happens, this seems like a pretty basic test of the style handling code. Seems like the diffing code doesn't look at style changes when deciding to update an element?

Workaround:

import karax / [kbase, vdom, kdom, vstyles, karax, karaxdsl, jdict, jstrutils, jjson]

var s1 = style(StyleAttr.color, "blue")

proc createDom(data: RouterData): VNode =
  result = buildHtml(tdiv):
    p(key="test" & s1.getAttr(StyleAttr.color), style = s1):
      text "change color!"
    button:
      text "Change Color"
      proc onclick(ev: Event; n: VNode) =
        echo "clicked"
        s1.setAttr("color", "red")

setRenderer createDom

from karax.

Seems like the diffing code doesn't look at style changes when deciding to update an element?

I'm pretty sure that's what we're doing.

from karax.

That's why I'm surprised - I've literally seen that code, and had it work in many cases, but I'm not super sure what's going on here.

from karax.