Ability to validate successful responder call about waterdrop HOT 4 CLOSED

@mensfeld no sarcasm intended! We built a fair amount of application specific abstraction on top of Karafka’s base classes. I’ll make it a priority to upgrade to 1.3 as there is other functionality we’re eager to make use of. I appreciate the support, I’ll reach out if we have any issues 👍

from waterdrop.

This functionality is already implemented in Waterdrop 2.0-alpha: https://github.com/karafka/waterdrop/tree/2.0 and won't be backported to 1.3. Sorry :(

Waterdrop 2.0 supports promises:

producer = WaterDrop::Producer.new

producer.setup do |config|
  config.kafka = { 'bootstrap.servers': 'localhost:9092' }
end

promise = producer.produce_async(topic: 'my-topic', payload: 'my message')
result = promise.wait
result.partition #=> 0
result.offset #=> 2065
result.error #=> nil

promise = producer.produce_async(topic: 'invalid-topic', payload: 'my message')
# On the wait you might as well get a timeout error if the delivery takes a lot of time
result = promise.wait
result.partition #=> 2
result.offset #=> 100
# This is not yet merged to rdkafka due to some internals problems with CI that we're trying to fix
result.error #=> "Some sort of error from librdkafka"

from waterdrop.

@mensfeld I appreciate the quick response! We're currently pinned to Karafka 1.2 as 1.3 resulted in breaking changes. This is yet another reason for us to resolve and upgrade. Thanks again 👍

from waterdrop.

I appreciate the quick response!

@nickoliver86 dunno if that was irony or not 🤔 ;) took me a while as I had sick leave.

Sorry for the fact, that 1.3 has breaking changes :( I do my best to keep as much of the backward compatibility and the API intact but that is not always an option :(

In case you didn't see: https://mensfeld.pl/2019/09/karafka-framework-1-3-0-release-notes-ruby-kafka/ - you can also reach out to me in case you need any help in the upgrade process.

I highly recommend upgrading to 1.3 as I plan to release Waterdrop 2.0 and make a patch to make it work with Karafka 1.3 (while Karafka 2.0 is under construction).

from waterdrop.