Code Monkey home page Code Monkey logo

Comments (8)

Kapiainen avatar Kapiainen commented on May 25, 2024

Try setting the Python path setting in the skin to python to show the terminal. That should hopefully give you a bit more info on what is going wrong on the Python side of things.

from lauhdutin.

BanCrash avatar BanCrash commented on May 25, 2024

If I do that without undo all the changes I made it only close right after opening.
Well, I will research to see if I can get it to work. Thanks for the fast answer.

from lauhdutin.

Kapiainen avatar Kapiainen commented on May 25, 2024

Are you sure that your modifications do not contain any invalid Python code? Sounds like the Python interpreter might be failing to parse your code. The backend scripts are set up to execute in a way that catches most runtime exceptions and shows the stack traceback rather than just close the terminal immediately. I think invalid Python code would be one of the few things to not be caught by that setup.

from lauhdutin.

Kapiainen avatar Kapiainen commented on May 25, 2024

By the way, I'm wondering if it would be more appropriate to just modify WindowsShortcuts.py to support subfolders. So e.g. shortcuts placed in \Lauhdutin\@Resources\Shortcuts\Origin would show up as being from the Origin platform. My reasoning is that:

  1. This would implement the ability to show a specific platform for an arbitrary number of possible values (Origin, Uplay, Itch.io, etc.). So no need to add a slightly modified copy of WindowsShortcuts.py for every platform.
  2. This would maintain consistency in terms of what needs to be done by the user. Properly supported platforms (e.g. Steam) have their games acquired in an automated fashion based upon one or more settings whereas in this case Windows shortcuts (and corresponding banners) have to be manually added by the user.

A new key-value pair could be added to the GameKeys enum and GAME_KEYS table on the Python and Lua parts of the skin, respectively. A new filter along the lines of shortcuts: followed by the subfolder name (e.g. shortcuts:origin) could be added.

What do you think?

from lauhdutin.

BanCrash avatar BanCrash commented on May 25, 2024

Probably is that, I am not much versed on python to be honest.

Sounds good, I think you are right, your way is much better than mine!

from lauhdutin.

Kapiainen avatar Kapiainen commented on May 25, 2024

I'll start working on that then.

from lauhdutin.

BanCrash avatar BanCrash commented on May 25, 2024

Thanks you so much, I tried it but I can't make it to work.

from lauhdutin.

Kapiainen avatar Kapiainen commented on May 25, 2024

Support has been added for one level of subfolders and the new-filter-tag branch has also been merged into next-version, which is where the development of version 2.7.0 will continue. The new-filter-tag branch will be deleted as soon as any pending pull requests have been resolved.

from lauhdutin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.