Code Monkey home page Code Monkey logo

Comments (30)

FranklinYu avatar FranklinYu commented on July 28, 2024 1

I see that "Make columns hideable" is checked as "done". How do I hide a column now? Let's say I want to hide all the servers/runtimes, how to?

from compat-table.

kangax avatar kangax commented on July 28, 2024

@fbender All good suggestions and all of these I've been planning to do in a near future!

from compat-table.

kangax avatar kangax commented on July 28, 2024

@fbender If you're still interested in tackling these, I'd be happy to pull them in. Otherwise, I'll try to get to this within a month or so.

from compat-table.

fbender avatar fbender commented on July 28, 2024

I'll have a look at it this week, however may not finish until the end of next week (depending on other work). If I don't report here, feel free to take over!

from compat-table.

kangax avatar kangax commented on July 28, 2024

Sounds good.

On Sun, Sep 22, 2013 at 10:59 PM, Florian Bender
[email protected]:

I'll have a look at it this week, however may not finish until the end of
next week (depending on other work). If I don't report here, feel free to
take over!


Reply to this email directly or view it on GitHubhttps://github.com/kangax/es5-compat-table/issues/75#issuecomment-24890439
.

from compat-table.

fbender avatar fbender commented on July 28, 2024

I have a minimal (somewhat dirty) fix at https://github.com/fbender/es5-compat-table/commits/es6-ux – do you agree with the course I take? Should I do something else?

No PR yet, because this fix would benefit from a refactoring, and it does not include item 2 (hiding arbitrary columns) & 3 (highlight current row/column) mentioned above.

Edit: Also, I only did minimal testing in Firefox, though this should work in "modern" browsers incl. IE9 (IE8 may need a script to make the checkbox work). I don't know if the results get skewed because of the hiding, either.

from compat-table.

kangax avatar kangax commented on July 28, 2024

@fbender Yes, I think it looks reasonable, although I already have a way of hiding old browsers in ES5 table. Not sure if you've seen — https://github.com/kangax/es5-compat-table/blob/gh-pages/master.css#L40-L46 It's purely presentational and done in CSS.

from compat-table.

fbender avatar fbender commented on July 28, 2024

Yeah, I saw that while I was already coding. I decided to keep my approach as it separates the data, logic, and appearance. This allows for only updating the data file and nothing else, and everything works as expected. As you can see, there's only an extra field in the JSON (obsolete == (true || false)) which lets the build script add an obsolete class to the respective table cells. Hiding the resp. cells is all done via CSS, too (but does not require changing the CSS file once you add/change/delete engines).

If you like, I can also change the ES5 et al. tables to use my current approach. Just let me know!

I think I'll break up the parts mentioned in the original issue request and do PRs one-by-one over the coming days/weeks (depending on the spare time I have). I'll also have a look at refactoring some of the code if you don't mind, while leaving my current code pretty much unchanged for the first PR (doing small steps to get things done).

from compat-table.

fbender avatar fbender commented on July 28, 2024

First part is now fixed in #88.

from compat-table.

kangax avatar kangax commented on July 28, 2024

Finished in kangax/es5-compat-table@0c9c2ba

from compat-table.

fbender avatar fbender commented on July 28, 2024

Yeah, that's much better, thanks a lot!

One more thing: I think it would be easier to make a column per software, and simply show a version for each feature-platform cell, like: http://en.wikipedia.org/wiki/Comparison_of_layout_engines_%28CSS%29 (with some adjustments, e.g. visually marking features that are only available in pre-release builds of a version but not the final builds).
This would be a bigger architectural change, and I'd like to give it a shot next week, if you give me a go.

from compat-table.

kangax avatar kangax commented on July 28, 2024

Hm, not a bad idea! Additionally, I would want to make header (with engine name + version) fixed; perhaps only when scrolling down. It's a bit difficult to inspect entries on a bottom right now.

from compat-table.

fbender avatar fbender commented on July 28, 2024

OK, I'll check it out.

The sticky header is a bit problematic, iirc in Firefox at least, but the new "position:sticky" property is being rolled out, and it should support what you'd like to see. Additionally, the script could break up the table into groups, so headers can be repeated between them … I'll see what I can do.

from compat-table.

kangax avatar kangax commented on July 28, 2024

Suggestion from twitter — https://twitter.com/kangax/status/405089875944546304

from compat-table.

kangax avatar kangax commented on July 28, 2024

Expanded checklist with more stuff

from compat-table.

fbender avatar fbender commented on July 28, 2024

This would be a bigger architectural change, and I'd like to give it a shot next week, if you give me a go.

Unsurprisingly, this did not happen. Though I'm willing to look at it during the holidays, and I'll report back mid-January.

from compat-table.

fbender avatar fbender commented on July 28, 2024

Though I'm willing to look at it during the holidays, and I'll report back mid-January.

Quick update: By now I built supporting infrastructure for the refactoring. I will continue with this work over the next few weeks. This is not on Github yet, I need to cleanup some stuff before I'm willing to push.

from compat-table.

kangax avatar kangax commented on July 28, 2024

Thanks!

Sent from my iPhone

On Jan 11, 2014, at 7:41, Florian Bender [email protected] wrote:

Though I'm willing to look at it during the holidays, and I'll report back mid-January.

Quick update: By now I built supporting infrastructure for the refactoring. I will continue with this work over the next few weeks. This is not on Github yet, I need to cleanup some stuff before I'm willing to push.


Reply to this email directly or view it on GitHub.

from compat-table.

fbender avatar fbender commented on July 28, 2024

Asana keeps bugging me to report my progress, unfortunately there's no progress to report. :(

It's still on my TODO but thesis and exams have priority right now. Will try to squeeze in more time in March / April.

from compat-table.

kangax avatar kangax commented on July 28, 2024

Sure, don't stress it!

Sent from my iPhone

On Feb 19, 2014, at 9:43, Florian Bender [email protected] wrote:

Asana keeps bugging me to report my progress, unfortunately there's no progress to report. :(

It's still on my TODO but thesis and exams have priority right now. Will try to squeeze in more time in March / April.


Reply to this email directly or view it on GitHub.

from compat-table.

aeosynth avatar aeosynth commented on July 28, 2024

how do i hide columns? clicking a header fades out the other columns, but they are still there taking up space

from compat-table.

kangax avatar kangax commented on July 28, 2024

@aeosynth why do you need the space there?

from compat-table.

aeosynth avatar aeosynth commented on July 28, 2024

i don't need the space there - it's simply easier to read if my eyes travel a shorter distance when flicking between the feature name and implementation. also, some users might not have widescreen monitors; removing the space would mean they could view the columns they're interested in without having to scroll

from compat-table.

kangax avatar kangax commented on July 28, 2024

I guess it might make sense. I'll see what I can do.

from compat-table.

webbedspace avatar webbedspace commented on July 28, 2024

I feel like my recent colourisation of Javascript engines sort-of fulfills the intended purpose of the last checkbox.

from compat-table.

kangax avatar kangax commented on July 28, 2024

I agree. It definitely comes very close if not solves it completely. Marking as done.

from compat-table.

kangax avatar kangax commented on July 28, 2024

@webbedspace Added 2 more things (on a bottom) that I think will improve overall experience. What do you think?

from compat-table.

fbender avatar fbender commented on July 28, 2024

Is somebody working on:

Replace bottom notes with inline tooltips (for convenience)

Otherwise I will do this next week.

from compat-table.

kangax avatar kangax commented on July 28, 2024

I think @webbedspace is working on eliminating some of the footnotes by adding corresponding subtests, but I'm not sure we'll be able to get rid of all footnotes this way; in which case, this could still be useful.

from compat-table.

fbender avatar fbender commented on July 28, 2024

I'd just add tooltips and keep the existing footnotes so there's no need for scrolling but the full list is readily available. Will do that next week. =

from compat-table.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.