Compatibility with Shaarli v0.12.0-beta about shaarli-material HOT 23 CLOSED

Hi @immanuelfodor,
Yes I definitely need to take some time to update the theme, I'll try to take a look either today or during the coming week, at least to make it work with the latest master from Shaarli. I'll keep you updated :)

from shaarli-material.

@kalvn Let me know if I can help.

from shaarli-material.

It's not exactly what you asked for, but you could use {$_PAGE_} which could fit your use case and are also used by plugins. However I need to fix an unnecessary breaking change in these values, as mentioned in the other thread.

from shaarli-material.

@immanuelfodor I merged shaarli/Shaarli#1536, it should fix the issue you had previously.

from shaarli-material.

The branch support-v012 was just finalized

@kalvn Awesome! You rule!

from shaarli-material.

Tested with the latest support-v012 branch, it's fixed, thanks! :)

from shaarli-material.

Updated all my plugins, they now work according to PR shaarli/Shaarli#1558 Also shaarli/Shaarli#1545 works fine with the theme. I think the support-v012 branch here can be also closed, it's up-to-date with master. Thank you all for being supportive over the years! ❤️

from shaarli-material.

@ArthurHoaro thanks! Actually I have a question: do you know if there's a way to retrieve the current URL path ($_SERVER['REQUEST_URI']) from templates?

I tried to access the $_SERVER variable from within templates but it cause errors (on contrary to $_GET which works fine). I need this to highlight current page in the tag.sort.html file.

from shaarli-material.

The branch support-v012 was just finalized. I tested it pretty intensively with Shaarli v0.12.0-beta and found no issues so far. I didn't create a release yet but if anyone wants to do some test on his side, I would greatly appreciate :)

I'll keep testing for a few days on my own and release it when Shaarli v0.12.0 is released.

from shaarli-material.

Did a git checkout to the new branch, works fine, looks awesome 🎉

However, I can't login at all after a logout. It seems to be a general Shaarli issue @ArthurHoaro on the master branch as the docker image was built from scratch. Deleted ipbans file, did a browser cache delete, used a different browser, nothing helped.

from shaarli-material.

I can't login even with the default template, this is an important info I think. The login redirect seems to be weird:

shaarli    | 192.168.1.3 - shaarli [02/Sep/2020:02:59:11 +0000] "POST /login?returnurl=%2F HTTP/1.1" 302 0 "https://shaarli.local/login?returnurl=%2F" "Mozilla/5.0...
shaarli    | 192.168.1.3 - shaarli [02/Sep/2020:02:59:11 +0000] "GET /login?returnurl=%2Flogin%3Freturnurl%3D%252F HTTP/1.1" 200 12197 "-" "Mozilla/5.0... 

from shaarli-material.

Maybe shaarli/Shaarli#1536 needs to be merged quick 😃

Edit: the force login false trick helped to get finally in.

from shaarli-material.

When editing a share on mobile, the FAB is shown and it is out of place:

from shaarli-material.

@immanuelfodor I found the responsible line: https://github.com/kalvn/Shaarli-Material/blob/support-v012/material/page.header.html#L173

I'll fix that asap :)

from shaarli-material.

It's fixed with the last commit.

from shaarli-material.

Hmm, I think I've found another bug: the CSS/JS resources are loaded without / at the beginning of the URL, so it becomes /admin/shaare/plugins/markdown_toolbar/includes/bootstrap_markdown/js/bootstrap-markdown.js for example which breaks the edit/add page resources as these are now requested from a folder too deep:

These weren't 404 URLs 4 days ago, so something must broke in the meantime.

from shaarli-material.

Or maybe Shaarli:master introduced a change that results in PluginManager::$PLUGINS_PATH becoming "slash-less"? 😀 @ArthurHoaro

from shaarli-material.

I think it's not related to Shaarli Material.

I would say plugin developers must ensure external resources are added with the base path, as it's done here for example: https://github.com/kalvn/shaarli2mastodon/blob/master/shaarli2mastodon.php#L75

from shaarli-material.

Wow, thanks for the example, I'm adding this to my plugins. Sorry for suspecting a bug here.

from shaarli-material.

Thanks but credit goes to https://github.com/shaarli/Shaarli/blob/master/plugins/wallabag/wallabag.php#L48 😉

from shaarli-material.

Just to give a little more info about why:

• we don't know if Shaarli is installed under a subfolder or not, so we can't use '/' . PluginManager::$PLUGINS_PATH
• before v0.12 every route were on the same folder level (domain.tld/shaarli/?do=route), so relative path worked fine. Now routes can be on multiple levels (e.g. /daily and /admin/* routes), so it requires to manually set the absolute path.

from shaarli-material.

Thanks for the insights! Based on this knowledge I also opened a shaarli-favicons PR to fix the same issue, shaaring is caring :) trailjeep/shaarli-favicons#3

from shaarli-material.

shaarli/Shaarli#1558 happened in the meantime, so I'll also revert any related changes. @kalvn said in shaarli/Shaarli#1548 (comment) that Shaarli Material has been also updated accordingly, so I think this ticket can be closed finally.

from shaarli-material.