Code Monkey home page Code Monkey logo

Comments (8)

andweber avatar andweber commented on May 18, 2024 1

I'm not familiar with audible but for me it looks like a bad way passing the root password around and (by the way) writing it down in debug logs.

Not sure what should happen, but on Ubuntu 16.04 the debug output is not changing whether I supply a valid password or not. Only if I leave it empty - it crashes.

from kalliope.

Sispheor avatar Sispheor commented on May 18, 2024

Maybe we can check before the installation if the sentence "become: true" is present in the install.yml.
But it wont disturb the install if you provide even if there is system package to install.

It works on Ubuntu. I dev on Ubuntu 16.04.
And yes, sudo is mandatory for Ansible to get admin privileges. We assume it is installed on the system. We can add something in the doc about this maybe.

from kalliope.

Sispheor avatar Sispheor commented on May 18, 2024

I think this is totally not a big deal to ask the sudo password every-time even if not necessary.

BTW, root user exist on Ubuntu, the password is disabled by default by the account is still present.

from kalliope.

bacardi55 avatar bacardi55 commented on May 18, 2024

It is indeed not a big deal and not a big key features, it is just that i like giving my password only when needed because any bad code having root access can be dangerous (even not intentionally).
That being said, I guess we can put this aside for now as not important.

The need of having sudo is important though for user on distro without sudo by default

from kalliope.

Sispheor avatar Sispheor commented on May 18, 2024

Todo list:

  • remove password from log output
  • fix crash when sudo password not provided

About the fact we ask the sudo password every time. As a playbook can contains multiple play, and in each play, the "become" command can be called in multiple level like in a task. We cannot know by advance if the sudo password will be required or not.
So we will still ask for it every time. After all, it's an installation, when you call pip, yum or apt you need to provide this password even if the package doesn't need it.

from kalliope.

andweber avatar andweber commented on May 18, 2024

Is there a reason that kalliope is not called with root priveleges?

sudo kalliope install --git-url https:\\xyz

or in a root shell. That would be the usual approach for apt and all the others?

from kalliope.

Sispheor avatar Sispheor commented on May 18, 2024

It's the usual approach for a package install. But we have based our module installation on Ansible and this one needs the sudo password inside its processing. Because the program is mostly used to deploy configuration on remote systems.

from kalliope.

Sispheor avatar Sispheor commented on May 18, 2024

Sudo is still required. But the password is now hidden.
Done in the last dev branch. Will be merged in master soon.

from kalliope.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.