Code Monkey home page Code Monkey logo

Comments (4)

kaleguy avatar kaleguy commented on June 14, 2024

This is intentional. You'll see that the page will still scroll if you have a scroll wheel or a trackpad, or you can use the arrow keys. (The arrow keys also will move the active item, so you'll need to hold down the Enter key to prevent that behavior).

The scrollbars were removed because they were causing clutter on Windows, which displays large ugly scrollbars. The left pane is particularly clunky looking with scrollbars since there can be bottom and right bars + the divider.

For people without a scroll wheel or trackpad no scrollbars is inconvenient though, so I'll add an option to put the scrollbars back. I'll close this issue once I've added it.

from leovue.

rogererens avatar rogererens commented on June 14, 2024

I see.
I discovered the scroll wheel behavior accidentally. I don't get your remark wrt the Enter key preventing the arrow key to change the active item selected: whatever I do, upon the key-release (or is it key-up) event the selection switches.

But another (quite important) aspect of scrollbars is that they also give a you visual cue that what is shown of a page in the viewport is not everything of the page.

For example, with my haphazardly chosen window size of the browser, I happened to see this screen shot at first, so it was much later I realized that I had overlooked some info on the page further down:
image

In my opinion, PyCharm keeps the clutter on an acceptable level when scrollbars are shown:
image

So I will be eagerly awaiting the option to enable scrollbars!
Very nice work, BTW :-)

from leovue.

kaleguy avatar kaleguy commented on June 14, 2024

Pycharm's scrollbars are fairly subtle, not so for Windows, especially older versions.

I use a Mac, which hides scrollbars in the browser (unless you are scrolling) so I got used to not using them as a visual cue for extended content.

I realized though, that the problem with the content pane wasn't the scrollbars, it was that they were appearing directly to the right of the centered content, not on the page right. If the vertical scrollbar is all the way to the right, it isn't a problem. So that is what I have implemented now:

  1. Content window gets scrollbar (all the way on right) when content is scrollable.
  2. Treemenu scrollbars remain hidden (otherwise in Windows you get a fat scrollbar next to the divider, which looks clunky. The divider needs to be there because in contrast to other left menu layouts, LeoVue trees can be quite wide so you need to be able to resize the tree menu pane easily.) However, with tree menu should be obvious when there is more content, and can scroll with arrow keys if no wheel or trackpad.

About the arrow keys, I mispoke, the shift key will stop the window from scrolling on Mac but menu item still changes, so can't be used to scroll Content pane.

The changes should be working on main site, but I haven't published to npm yet so they aren't implemented with the CDN version yet. Will publish once I've had a chance to do a bit more testing. Let me know if you see any problems, and thanks for the tip.

from leovue.

kaleguy avatar kaleguy commented on June 14, 2024

Published to 1.17.0, so works on CDN now.

from leovue.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.