[@kadena/client] Commandbuilder: null proof in continuation about kadena.js HOT 5 CLOSED

I suppose this issue needs to be resolved before kadena.js can be used with Marmalade.

from kadena.js.

I suppose this issue needs to be resolved before kadena.js can be used with Marmalade.

Yes, you're right. I would be better....

But in the meantime, I found out a workaround (I'm not very proud of it)

https://github.com/CryptoPascal31/marmalade-ng-sweep-bot/blob/44d1d817992225f40adf9c3e55141981beb2295e/marmalade_ng_client.js#L4

from kadena.js.

Based on the api specification it says the proof could be only a base64 string if presented.
https://api.chainweb.com/openapi/pact.html#tag/model-payload
So if there is no proof you don't need to pass the proof field

const cmd = Pact.builder.continuation({
  pactId:"4UdU0LY5hNCNQuuuRAmXKGHf2Q2S4OUAYnEo5X7B60Y", 
  step:0, 
  rollback:true
})

if this throws an exception then we need to update the api specification as well
Could you please check if not passing proof solves the issue?

from kadena.js.

According to the Pact code:
https://github.com/kadena-io/pact/blob/445af04190793a1d8fbbfad626e25fb7f4a0c02c/src/Pact/Types/RPC.hs#L98

the field proof is mandatory: Aeson's .: operator.

btw: this should be confirmed by an Haskell/Aeson guru

from kadena.js.

I haven't tested until now.
But the merged PR should fix the issue => I'm closing.

from kadena.js.