Code Monkey home page Code Monkey logo

Comments (3)

kachayev avatar kachayev commented on May 18, 2024 2

Hey! Thanks a lot for the feedback.

Yeah, I saw implementation from the contrib package. Though masking itself seemed to me like not the trickiest part of the implementation. And the very first idea with putting masks into observations dictionary to simply mask out logits in a custom mlp_extractor ... just worked out. That's why I didn't look deeply into MaskablePPO implementation. And because PPO itself in algorithms with such a large number of implementation details, the initial goal was to touch as little of the algo itself as possible (ideally, no changes at all).

Regarding the version, the latest version of gym-microrts==0.5.0. requires gym>=0.20.0 which turned out to be incompatible with stable_baselines3==1.3.0. Previously I used MicroRTS 0.4.3 with SB3 1.3.0 but that required me to reimplement some pieces of the environment logic only available in the latest release. I'm not sure if Gym version is critical for MicroRTS, need to do more experiments with different version. It might be easier to wait for SB3 to add support for the latest Gym though 😀

from gym-microrts-paper-sb3.

araffin avatar araffin commented on May 18, 2024

for gym, this will probably solve your issue: DLR-RM/stable-baselines3#674 (comment)

we don't support it yet as we want to avoid breaking changes and bad surprises for users.

from gym-microrts-paper-sb3.

kachayev avatar kachayev commented on May 18, 2024

Yeah, I saw the thread. Seems like a lot of work, thanks for paying so much attention to details! Ultimately, I've decided to wait when it's merged to update 😀

from gym-microrts-paper-sb3.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.